gh-124040: adjust few tests in testHypot/testDist to get exactly computed results #124042
+8
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
skirpichev
commented
Sep 13, 2024
•
skirpichev
commented
- Issue: testHypot in test_match uses assertEqual on floats #124040
One-argument form is enough to test L2636 and compare computed values exactly.
skirpichev
force-pushed
the
simplify-hypot-test-124040
branch
from
6a8e159
to
a4b73dd
Compare
serhiy-storchaka
approved these changes
Sep 13, 2024
This comment was marked as outdated.
This comment was marked as outdated.
skirpichev
changed the title
|
OP confirmed that this solves issue: #124040 (comment) |
skirpichev
added
needs backport to 3.11
|
Since #102837 is in >=3.11 - backports requested. |
|
Thanks @skirpichev for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 19, 2024
…y computed results (pythonGH-124042) (cherry picked from commit 4420cf4) Co-authored-by: Sergey B Kirpichev <[email protected]>
|
GH-124235 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 19, 2024
…y computed results (pythonGH-124042) (cherry picked from commit 4420cf4) Co-authored-by: Sergey B Kirpichev <[email protected]>
|
GH-124236 is a backport of this pull request to the 3.12 branch. |
|
Bad for 3.11, but this is not a security issue. |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Sep 19, 2024
…ly computed results (GH-124042) (GH-124236) (cherry picked from commit 4420cf4) Co-authored-by: Sergey B Kirpichev <[email protected]>
savannahostrowski
pushed a commit
to savannahostrowski/cpython
that referenced
this pull request
Sep 22, 2024
…y computed results (pythonGH-124042)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.