gh-131647: fix 'sys.path_hooks is empty' warning in test_permission_e… #131648
Conversation
graingert
requested review from
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
| @@ -158,11 +158,15 @@ def test_deleted_cwd(self): | |||
| def test_permission_error_cwd(self): | |||
| # gh-115911: Test that an unreadable CWD does not break imports, in | |||
| # particular during early stages of interpreter startup. | |||
|
|
|||
| def noop_hook(*args): | |||
There was a problem hiding this comment.
noop name is misleading, since the hook actually does something, raise ImportError :-) I suggest to rename the function to something like failing_path_hook.
There was a problem hiding this comment.
I'm not familiar with path_hooks but a noop hook is one that causes the processing to continue checking other hooks and return None if there's no others
This hook doesn't fail, eg the error is immediately caught and has no change in behavior over having no hooks other than not warning
There was a problem hiding this comment.
I'm happy to rename it, but with "failing_path_hook" it would appear that the test was about the failing hook rather than the permission error because the new name attracts too much attention
There was a problem hiding this comment.
Well, the name of the function doesn't matter much. I merged your PR ;-)
|
Merged, thanks for the fix. |
…rror_cwd