gh-132038: Make perf version check in test_perf_profiler more robust #132039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should work also if the version string includes a commit hash, like `perf version 6.12.9.g242e6068fd5c`
AA-Turner
approved these changes
Apr 3, 2025
| @@ -501,7 +501,7 @@ def _is_perf_version_at_least(major, minor): | |||
| version = output.split()[2] | |||
| version = version.split("-")[0] | |||
| version = version.split(".") | |||
| version = tuple(map(int, version)) | |||
| version = tuple(map(int, version[:2])) | |||
There was a problem hiding this comment.
Perhaps add a note to the comment at the start of the function?
|
@itamaro backports? |
yeah we can backport to 3.13. not relevant to 3.12. |
|
Thanks @itamaro for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 4, 2025
…obust (pythonGH-132039) Should work also if the version string includes a commit hash, like `perf version 6.12.9.g242e6068fd5c` (cherry picked from commit b6c92ec) Co-authored-by: Itamar Oren <[email protected]>
|
GH-132058 is a backport of this pull request to the 3.13 branch. |
seehwan
pushed a commit
to seehwan/cpython
that referenced
this pull request
Apr 16, 2025
…obust (python#132039) Should work also if the version string includes a commit hash, like `perf version 6.12.9.g242e6068fd5c`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should work also if the version string includes a commit hash, like
perf version 6.12.9.g242e6068fd5c