gh-136438: Make sure test_ast pass with all optimization levels
#136596
+13
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Eclips4
reviewed
Jul 17, 2025
| @@ -131,7 +131,7 @@ def test_snippets(self): | |||
| (eval_tests, eval_results, "eval")): | |||
| for i, o in zip(input, output): | |||
| with self.subTest(action="parsing", input=i): | |||
| ast_tree = compile(i, "?", kind, ast.PyCF_ONLY_AST) | |||
| ast_tree = compile(i, "?", kind, ast.PyCF_ONLY_AST, optimize=0) | |||
There was a problem hiding this comment.
Suggested change
| ast_tree = compile(i, "?", kind, ast.PyCF_ONLY_AST, optimize=0) | |
| ast_tree = compile(i, "?", kind, ast.PyCF_ONLY_AST, optimize=False) |
Let's unify it, provided it doesn't break anything.
|
I believe the explanation is as follows: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now tests pass with all combinations of -OO and --without-doc-strings.
It was long lists of errors before, but all proposed fixes are just to add some needed
optimize=Falseoptions.-OO#136438