gh-139743: avoid import-time print in test_sqlite3 that leaks into help('modules') #139746
+2
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
added
tests
|
Thanks @ttw225 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 9, 2025
…9746) (cherry picked from commit 6508940) Co-authored-by: Peter <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 9, 2025
…9746) (cherry picked from commit 6508940) Co-authored-by: Peter <[email protected]>
|
GH-139828 is a backport of this pull request to the 3.14 branch. |
|
GH-139829 is a backport of this pull request to the 3.13 branch. |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Oct 9, 2025
…GH-139829) (cherry picked from commit 6508940) Co-authored-by: Peter <[email protected]>
serhiy-storchaka
pushed a commit
that referenced
this pull request
Oct 9, 2025
…GH-139828) (cherry picked from commit 6508940) Co-authored-by: Peter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-139743: importing test_sqlite3 printed the SQLite version banner, which leaked into help('modules'). Move the print under load_tests (still under verbose) so it only appears when tests actually run.
Credit: thanks to @yihong0618 for identifying the cause and approach.
(No NEWS — tests-only.)