gh-139778: Assertion fix in code_returns_only_none
#139779
Open
+33
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've removed incorrect assertion, reorganize a little and update code comments. |
Objects/codeobject.c
Outdated
|
|
||
| // That means there must be | ||
| // an explicit return (non-None), or it only raises. | ||
| // The last instruction mostly either returns or raises. |
There was a problem hiding this comment.
What about raises? Do you need to handle it?
There was a problem hiding this comment.
No, raises can't change return value of a function. There was only one incorrect assumption that each function should end with either return or raise if there's no None in the list of constants. But we can preserve old checking, because we only need to find return statement.
| } | ||
| // It must only raise. | ||
|
|
||
| none_index = -1; |
There was a problem hiding this comment.
I believe you have to add comments here or below where you use this value.
There was a problem hiding this comment.
What kind of comments?
|
CC @picnixz. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code_returns_only_none#139778