-
-
Notifications
You must be signed in to change notification settings - Fork 33.1k
gh-90949: Recommend hasattr
with Expat security methods
#139800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This mimics existing method SetReparseDeferralEnabled.
.. to make it consistent with the other four Expat security methods.
hasattr
with Expat security methods
…otes .. to make it consistent with Doc/library/pyexpat.rst.
@picnixz I'm reading that as merging at least one of the unmerged backports of #139234 first — sure.
It's got a bit less loud in the meantime when adding the ![]()
So there is a threshold where above a note gets its own box and below a box takes too much attention, makes sense.
It would be multiple smaller blocks, not one huge block though. It's a bit less scary than that. Btw I have no plans of adding more, new API like that will only appear if there is no way around it.
Personally I think that see also requires an additional click and additional energy and that alone will many users stop from ever noticing. (I also believe readability is not in danger currently.) Let me demo what we get when taking the |
@picnixz pushed. |
Same idea (and approach) as #116278.
CC @picnixz
📚 Documentation preview 📚: https://cpython-previews--139800.org.readthedocs.build/