Skip to content

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Oct 8, 2025

(cherry picked from commit 678e0b8)

Co-authored-by: sobolevn [email protected]

)

(cherry picked from commit 678e0b8)

Co-authored-by: sobolevn <[email protected]>
@hugovk
Copy link
Member

hugovk commented Oct 9, 2025

I pushed Ruff's lint+format fixes, which use target-version = "py310" (via .ruff.toml).

But Tools/wasm/mypy.ini has:

# Make sure the wasm can be run using Python 3.8:
python_version = 3.8

So there's a mismatch.

Also Tools/wasm/mypy.ini was deleted in main (ee49644 and 14291fa) so shall we also delete it in these backports?

@hugovk hugovk requested a review from ezio-melotti as a code owner October 9, 2025 06:40
@brettcannon
Copy link
Member

I opted out of mypy for the WASI stuff, so that's a question for @freakboy3742 and @hoodmane .

Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't been systematically running mypy locally, so it's probably safer to leave off the Emscripten code for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants