[3.15] gh-155727: Ignore internal imports in test_attribute_completion (GH-155730) - #155769
Open
miss-islington wants to merge 1 commit into
Open
[3.15] gh-155727: Ignore internal imports in test_attribute_completion (GH-155730)#155769miss-islington wants to merge 1 commit into
miss-islington wants to merge 1 commit into
Conversation
…pythonGH-155730) Reader.run_hooks() imports _pyrepl._threading_handler lazily, and the test counted it as a module imported by the completer. (cherry picked from commit 94c606652c4943cb57ec7858d723511559849aab) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington
requested review from
ambv,
lysnikolaou and
pablogsal
as code owners
August 14, 2026 04:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reader.run_hooks() imports _pyrepl._threading_handler lazily, and the
test counted it as a module imported by the completer.
(cherry picked from commit 94c6066)
Co-authored-by: Serhiy Storchaka storchaka@gmail.com