Conversation
…during fetch
Nested Cursor.execute() during fetch is already rejected with
ProgrammingError ("Recursive use of cursors not allowed"). The shared
error path in _pysqlite_query_execute still set locked=0 and
Py_CLEAR'd self->statement, so the outer fetch then dereferenced a
NULL statement in _pysqlite_fetch_one_row.
Return immediately when check_cursor() fails at entry instead of
jumping to that cleanup. Add regression tests for text_factory and
converter callbacks that call execute() mid-fetch.
Fixes python#157564
|
All commit authors signed the Contributor License Agreement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nested
Cursor.execute()during fetch is already rejected withProgrammingError("Recursive use of cursors not allowed"). The shared error path in_pysqlite_query_executestill setlocked=0andPy_CLEAR'dself->statement, so the outer fetch then dereferenced aNULLstatement in_pysqlite_fetch_one_row.Return immediately when
check_cursor()fails at entry instead of jumping to that cleanup. Add regression tests fortext_factoryand converter callbacks that callexecute()mid-fetch.Fixes #157564