Move NEWS entries to pull-request-lifecycle #1506
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6860013.
|
See also would be nice but it seems to make the section quoted. |
hugovk
reviewed
Feb 3, 2025
Co-authored-by: Hugo van Kemenade <[email protected]>
|
I must have done something weird before it works when I tried again! |
picnixz
reviewed
Mar 13, 2025
Co-authored-by: Bénédikt Tran <[email protected]>
picnixz
approved these changes
Mar 13, 2025
There was a problem hiding this comment.
We improved a bit the content, but not by much, so it's fine to make it part of this change. I think we need a follow-up PR to improve the cases where a NEWS entry is necessary (see python/cpython#131177 (comment)). OTOH, you can revert the 3.X.rst mention and make it part of the follow-up PR.
Before merging, I'll check that the rst:role is correctly linked though.
|
Arf, it appears that we don't have the cross-referencing:
Well, let's introduce intersphinx in a future PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1242.
📚 Documentation preview 📚: https://cpython-devguide--1506.org.readthedocs.build/getting-started/pull-request-lifecycle/#what-s-new-and-news-entries