Skip to content

Document how to use varargs in Argument Clinic #1629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Document how to use varargs in Argument Clinic #1629

wants to merge 5 commits into from

Conversation

skirpichev
Copy link
Contributor

@skirpichev skirpichev commented Aug 12, 2025 •
edited by github-actions bot
Loading

@aisk @JelleZijlstra @skirpichev
Document how to use varargs in Argument Clinic
436be4a 
Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Sergey B Kirpichev <[email protected]>
@skirpichev
Copy link
Contributor Author

This is a minor correction of closed pr #1277 (now var-positional arguments passed a C array). The rest looks fine for me.

@skirpichev skirpichev mentioned this pull request Aug 12, 2025
Open
vstinner
vstinner reviewed Aug 13, 2025
View reviewed changes
@AA-Turner @skirpichev
Update development-tools/clinic.rst
16237b2 
Co-authored-by: Sergey B Kirpichev <[email protected]>
AA-Turner
AA-Turner reviewed Aug 15, 2025
View reviewed changes
AA-Turner
AA-Turner reviewed Aug 15, 2025
View reviewed changes
skirpichev
skirpichev commented Aug 15, 2025
View reviewed changes
skirpichev
skirpichev commented Aug 15, 2025
View reviewed changes
AA-Turner
AA-Turner requested changes Aug 15, 2025
View reviewed changes
Copy link
Member

@AA-Turner AA-Turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should mention both the tuple and array converters, they do different things. Notably array results in PyObject * const *args and Py_ssize_t args_length, whereas tuple just passes a regular PyTupleObject.

Also, I found the PR where : object was removed (python/cpython#126560 by @serhiy-storchaka)

@skirpichev
Copy link
Contributor Author

Also, I found the PR where : object was removed

It's not removed, just an alias for tuple.

@skirpichev skirpichev requested a review from AA-Turner August 16, 2025 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner left review comments

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland

@AA-Turner AA-Turner Awaiting requested review from AA-Turner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skirpichev @vstinner @AA-Turner @aisk