[docs] move --use-fine-grained-cache to Incremental group #20176
+6
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
ilevkivskyi
reviewed
Nov 8, 2025
Member
ilevkivskyi
left a comment
ilevkivskyi
left a comment
There was a problem hiding this comment.
TBH, I am not really the owner of this feature. But also I think it is in misc intentionally, incremental_group is used for the regular (coarse-grained) incremental mode, while this is flag if for mypy daemon (fine-grained incremental) mode.
Contributor
Author
|
Seems to me that if |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves
--use-fine-grained-cacheout of misc into incremental, a cli documentation group that seems more suitable. It also notes that the flag can only be used in dmypy.@ilevkivskyi, you seem like something of a "code owner" for this feature, so feel free to close this PR if you thought the old location was better — you would know! 🙂