-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Initial implementation of parallel type checking #20280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ilevkivskyi
wants to merge
25
commits into
python:master
Choose a base branch
from
ilevkivskyi:simple-parallel
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+759
−201
Open
Changes from 17 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
8853a1b
Initial random experiments
ilevkivskyi 37533da
Play more with GC
ilevkivskyi 465d84b
Add some error handling logic
ilevkivskyi 76e00ce
Better handling of the GC trick
ilevkivskyi 3a5bc3c
Basic handling for blockers
ilevkivskyi 25ca8d5
Basic crash handling
ilevkivskyi 5775df5
Better testing support
ilevkivskyi 8e901f9
Merge remote-tracking branch 'upstream/master' into simple-parallel
ilevkivskyi 2cd69e4
Better testing support
ilevkivskyi 1e5b1fe
Skip some tests
ilevkivskyi 518218e
Fix custom error codes
ilevkivskyi 2d70d59
Skip couple more tests for now
ilevkivskyi fa50b91
Add CI jobs
ilevkivskyi f69b81b
Undo unnecessary changes
ilevkivskyi 3e6ff9d
Some refactoring
ilevkivskyi f70123a
Add some docs/comments
ilevkivskyi 42a530d
One more comment; fix a typo
ilevkivskyi d63a2fc
Address CR
ilevkivskyi 1cb50dd
Fix --sqlite-cache
ilevkivskyi 1c23255
Merge remote-tracking branch 'upstream/master' into simple-parallel
ilevkivskyi 90cc500
Merge remote-tracking branch 'upstream/master' into simple-parallel
ilevkivskyi 8126bc1
Apply black
ilevkivskyi df84adb
A tiny refactor
ilevkivskyi d59494d
Merge remote-tracking branch 'upstream/master' into simple-parallel
ilevkivskyi 1b7ed16
Fix merge
ilevkivskyi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to add some test cases that are specifically designed to test parallel type checking, e.g. a long import chain, or potential for large number of parallelism (no need to do this in this PR)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I was thinking about this. I will add this to the list of follow-up items in PR description so that I will not forget about it.