[mypyc] Replace _CPyObject_HasAttr with PyObject_HasAttrWithError #20535
+2
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Followup to #20460 (comment) |
A5rocks
reviewed
Jan 6, 2026
mypyc/lib-rt/dict_ops.c
Outdated
| if (PyDict_CheckExact(dict)) { | ||
| // Argh this sucks | ||
| if (PyDict_Check(stuff) || _CPyObject_HasAttr(stuff, mypyc_interned_str.keys)) { | ||
| if (PyDict_Check(stuff)|| PyObject_HasAttrWithError(stuff, mypyc_interned_str.keys)) { |
Collaborator
There was a problem hiding this comment.
Wouldn't this return -1 on failure which would be bad and trigger the if? (when would that failure be...)
I'm not very familiar with C so maybe I'm wrong :/
Collaborator
Author
There was a problem hiding this comment.
Wouldn't this return
-1on failure
Yes, but that's already returned from _CPyObject_HasAttr on failure as well.
https://docs.python.org/3/c-api/object.html#c.PyObject_GetOptionalAttr
Collaborator
There was a problem hiding this comment.
I guess if you want minimal PRs this can be fixed in a followup then...
Collaborator
Author
There was a problem hiding this comment.
Just pushed a new commit to explicitly check for > 0. That should resolve that issue as well.
A5rocks
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.python.org/3/c-api/object.html#c.PyObject_HasAttrWithError