Clarify implicit_reexport with strict mode#21704
Open
ahmojo wants to merge 2 commits into
Open
Conversation
JukkaL
reviewed
Jul 8, 2026
| Although this option is enabled by default, :confval:`strict` enables | ||
| :option:`mypy --no-implicit-reexport`. Set ``implicit_reexport = true`` | ||
| explicitly if you want to keep implicit reexports when using strict mode. | ||
|
|
Collaborator
There was a problem hiding this comment.
Please move this paragraph to be after the example code block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16971.
Summary
Clarifies that
implicit_reexportis enabled by default in normal configuration, butstrictenables--no-implicit-reexportunless users explicitly setimplicit_reexport = true.Why
The implementation default is still
implicit_reexport = true, but users running withstrict = truecan observe behavior equivalent toimplicit_reexport = false. This keeps the existing behavior and documents the strict-mode interaction near the config option.Validation
--strictreports[attr-defined]for the implicit reexport.strict = truereports[attr-defined].strict = trueplusimplicit_reexport = truepasses.sphinx-build -b html ...against a copied docs source tree succeeded; it emitted existingchangelogtoctree warnings.