Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint: Normalise whitespace, remove the Emacs stanza, remove unneeded headers #4081

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented Oct 24, 2024

Alternative to #4078.

cc: @hugovk

My proposal would be to temporarily enable rebase merging, rebase-merge this, and then disable it, so that we still have somewhat meaningful individual commits but minimise the number of times people are pinged.

If we merge this, I'll follow up with a PR to the tooling.

A


📚 Documentation preview 📚: https://pep-previews--4081.org.readthedocs.build/

@AA-Turner AA-Turner added the lint Linter-related work and linting fixes on PEPs label Oct 24, 2024
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My proposal would be to temporarily enable rebase merging, rebase-merge this, and then disable it, so that we still have somewhat meaningful individual commits

I'm fine with a squash merge, it's all cleanup.

Copy link
Contributor

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, too! Let's merge this and close #4078.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lint Linter-related work and linting fixes on PEPs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants