Skip to content

Conversation

skirpichev
Copy link
Contributor

@skirpichev skirpichev commented Oct 7, 2025

  • Change is either:
    • To a Draft PEP
    • To an Accepted or Final PEP, with Steering Council approval
    • To fix an editorial issue (markup, typo, link, header, etc)
  • PR title prefixed with PEP number (e.g. PEP 123: Summary of changes)

📚 Documentation preview 📚: https://pep-previews--4639.org.readthedocs.build/

https://pep-previews--4639.org.readthedocs.build/pep-0791/

@skirpichev
Copy link
Contributor Author

N/B: This extends c_div() example and adds a trivial note that a separate namespace is good also to avoid name conflicts (with example).

I'll wait for more feedback in the d.p.o thread, then make this ready for review.

@vstinner
Copy link
Member

vstinner commented Oct 7, 2025

You should also update the PEP to use math.integer namespace, no?

@skirpichev
Copy link
Contributor Author

You should also update the PEP to use math.integer namespace, no?

I'm not sure. IMO, this should be postponed till final resolution of the SC.

On one hand, SC preference was expressed sufficiently clear. On another hand, this will also require adjustment in the implementation. That might be a waste of work.

I think it's clear that it's a minor point and that decision on module naming - left to SC.

@vstinner
Copy link
Member

vstinner commented Oct 8, 2025

SC expressed a strong preference for math.integer name. I suggest updating the PEP now to make it more likely to be accepted by the SC.

@skirpichev skirpichev marked this pull request as ready for review October 10, 2025 14:52
@skirpichev skirpichev requested a review from vstinner as a code owner October 10, 2025 14:52
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@skirpichev: Tell me when it's ready to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants