-
Notifications
You must be signed in to change notification settings - Fork 619
Update website for Python install manager #2717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The CI errors aren't mine:
I suspect in any case this PR probably needs to be split up to change the DB first so that we can have at least one release in it before updating the templates? |
Okay, with those template tweaks the visuals should be entirely unaffected if there are no PyManager releases registered, which should mean it can all be deployed at once and we get no changes until we put up a release. |
Hi @zooba, all looks good after review—are you ready to merge this? Thanks for the PR :) |
I think so, but I am exceedingly nervous about it! If it looks good to you, and it's easy enough to roll back if needed, then go ahead. |
This is not ready to merge yet! But it's the area I'm most uncomfortable with updating, so I'm getting the PR out early.
@ambv suggested that we should treat PyManager releases as another Python release, so I think that's what I've enabled. This will put them in all the same release lists as Python (as long as downloads only exist for Windows, I believe it won't appear on other OS lists), and it makes updating the "Download latest" buttons a bit easier.
I'm leaving the old installer available in those popups for as long as it exists, so that we don't seem quite as pushy. The installer will have its own message warning about deprecation. Eventually I'd like to replace these messages with a "Run
py install {version}
" message, but haven't quite figured that part out - it's not urgent.Very open to any kind of help/feedback/assistance here, this is somewhat out of my depth, and while I could spend time learning all the ins and outs, I'd rather just ask for help :)