Make type of unitest.mock.Any a subclass of Any
#14708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another approach suggested by @srittau is having |
This comment has been minimized.
This comment has been minimized.
hauntsaninja
approved these changes
Sep 12, 2025
sobolevn
reviewed
Sep 13, 2025
stdlib/unittest/mock.pyi
Outdated
| @@ -513,7 +513,8 @@ class _ANY: | |||
| def __ne__(self, other: object) -> Literal[False]: ... | |||
| __hash__: ClassVar[None] # type: ignore[assignment] | |||
|
|
|||
| ANY: _ANY | |||
| # See https://github.com/python/typeshed/issues/14701 | |||
| ANY: Any | |||
|
if it's a working solution, I think a subclass of Any is preferable, given that: |
This comment has been minimized.
This comment has been minimized.
srittau
approved these changes
Sep 14, 2025
|
LGTM, although we could add some tests to ensure that the problem mentioned in #14701 is fixed. Also, the example from the docs seems worthwhile to add as a test. |
brianschubert
changed the title
mock.ANY changesunitest.mock.Any a subclass of Any
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #14701