Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyright test dependency to 1.1.299 #9958

Merged
merged 2 commits into from
Mar 27, 2023
Merged

Bump pyright test dependency to 1.1.299 #9958

merged 2 commits into from
Mar 27, 2023

Conversation

AlexWaygood
Copy link
Member

No description provided.

pyproject.toml Outdated Show resolved Hide resolved
@AlexWaygood AlexWaygood changed the title Bump pyright test dependency to 1.1.300 Bump pyright test dependency to 1.1.299 Mar 27, 2023
@srittau
Copy link
Collaborator

srittau commented Mar 27, 2023

It looks to me as if the 1.1.300 errors are related to annotations like:

    foo: int = ...

I wouldn't mind if we'd "fix" them. (Actually I'm a bit surprised we don't have a flake8-pyi check.)

@srittau
Copy link
Collaborator

srittau commented Mar 27, 2023

PyCQA/flake8-pyi#98

@AlexWaygood
Copy link
Member Author

AlexWaygood commented Mar 27, 2023

PyCQA/flake8-pyi#98

Ugh, that again, coming back to haunt us :///

Tbh, I think it may be a bug in pyright (though yes, we should obviously use the = ... idiom as sparingly as possible). I thought ... was meant to be compatible with any type, at least in stubs.

But anyway, too much to work through right now! I really just wanted to see whether the pyright bugs I'm seeing in the CI for #9957 can be reproduced with a more up-to-date version of pyright.

@AlexWaygood AlexWaygood merged commit 20f9b36 into main Mar 27, 2023
@AlexWaygood AlexWaygood deleted the pyright-bump branch March 27, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants