Skip to content

remove std out in EEG estimator #4832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

remove std out in EEG estimator #4832

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54e45ec
convert batch size to float before torch.std in params reporter
YanXiong-Meta Sep 6, 2025
8b481cf
remove std out in EEG estimator
YanXiong-Meta Sep 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fbgemm_gpu/fbgemm_gpu/tbe/stats/bench_params_reporter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ def extract_params(
for bs in batch_size_per_feature_per_rank
for b in bs
]
)
).float()
)
)
)
Expand Down
4 changes: 0 additions & 4 deletions fbgemm_gpu/src/tbe/eeg/indices_estimator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,16 +163,12 @@ ZipfParameters IndicesEstimator::zipfParams(

if ((ratio < kHeavyHitterLowerBound_) ||
(ratio > kHeavyHitterUpperBound_)) {
std::cout << "Skipping (s,q) (" << s << ", " << q
<< "): " << " inconsistent with heavy hitters!" << "\n";
continue;
}

double logLikelihood = -zipfTotalFreq * log(normalizeConst) +
s * freqTerm - kQRegularizer_ * q;
if (logLikelihood > maxLogLikelihood) {
std::cout << "Found best Log likelihood so far on (s,q) (" << s << ", "
<< q << "): " << logLikelihood << "\n";
maxLogLikelihood = logLikelihood;
zipfParams.q = q;
zipfParams.s = s;
Expand Down
Loading