bwd case when offset is 0 #4963
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This case is for when we are not using bottom right mask. It should be slightly better perf in that case. # notes We note that backward is in general not stable. Sometimes you can get IMA. And numerics are not as good as we want it to be. Differential Revision: D83076701
|
@henrylhtsang has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83076701. |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This case is for when we are not using bottom right mask.
It should be slightly better perf in that case.
notes
We note that backward is in general not stable. Sometimes you can get IMA. And numerics are not as good as we want it to be.
Differential Revision: D83076701