Remove guard_size_oblivious from embedding_backward_split_meta_template. #4973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Have the same "intended" semantics of guard_size_oblivious here, if idk, i assume its True. guard_size_oblivuous will be deprecated. Reviewed By: q10 Differential Revision: D83884674
Summary: X-link: facebookresearch/FBGEMM#1990 guard_size_oblivious will be deprecated. Differential Revision: D83886041
|
@laithsakka has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83886041. |
✅ Deploy Preview for pytorch-fbgemm-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: https://github.com/facebookresearch/FBGEMM/pull/1990
guard_size_oblivious will be deprecated.
Differential Revision: D83886041