Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added flux demo #3418

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Added flux demo #3418

wants to merge 4 commits into from
+220 −97

Conversation

cehongwang
Copy link
Collaborator

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@github-actions github-actions bot added component: conversion Issues re: Conversion stage component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Feb 27, 2025
@cehongwang cehongwang marked this pull request as draft February 27, 2025 00:39
@github-actions github-actions bot requested a review from peri044 February 27, 2025 00:39
peri044
peri044 reviewed Feb 27, 2025
View reviewed changes
py/torch_tensorrt/dynamo/conversion/_TRTInterpreter.py Outdated
Comment on lines 708 to 715
# TODO: Memory control prototyping. Under discussion
self.module.to("cpu")
torch.cuda.empty_cache()
del self.module
gc.collect()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use delete module call here

narendasan
narendasan reviewed Feb 27, 2025
View reviewed changes
demo/flux_demo.py Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move to examples

@narendasan
Copy link
Collaborator

Can the app display the inference time, might be nice to have some stats rendered live as you generate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan left review comments

@peri044 peri044 peri044 left review comments

Assignees
No one assigned
Labels
cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cehongwang @narendasan @peri044 @facebook-github-bot