fix: Inferred dimensions at build time in reshape #3746
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: conversion
peri044
reviewed
Sep 19, 2025
Comment on lines
+52
to
+68
| total_elements = 1 | ||
| for s in input.shape: | ||
| if s != -1: | ||
| total_elements *= s | ||
|
|
||
| # Divide by known dimensions in new_shape to find the inferred dimension | ||
| # This ensures the total number of elements remains the same | ||
| for s in new_shape: | ||
| if isinstance(s, int) and s != -1: | ||
| if total_elements % s != 0: | ||
| raise ValueError( | ||
| f"Cannot infer dimension: {total_elements} elements not divisible by {s}" | ||
| ) | ||
| total_elements //= s | ||
|
|
||
| # Replace -1 with the calculated inferred dimension | ||
| new_shape[inferred_dim_index] = total_elements |
There was a problem hiding this comment.
could you please give an example here ?
|
I had issue with TinyLlama/TinyLlama-1.1B-Chat-v1.0 model with nvpf4 quantization. But this problem is not present with the latest torch-TRT. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added special case handling in the reshape operation to detect and handle cases involving dynamic shape and inferred dim.
This new logic in reshape:
Fixes #3745
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: