Skip to content

Conversation

@Xia-Weiwen
Copy link
Collaborator

As the title

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3365

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 20c6579 with merge base 257d18a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 21, 2025
@Xia-Weiwen Xia-Weiwen added topic: bc-breaking Use this tag if this PR breaks backward compatibility and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Nov 21, 2025
@Xia-Weiwen Xia-Weiwen marked this pull request as ready for review November 21, 2025 05:41
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 21, 2025
Copy link
Contributor

@jerryzh168 jerryzh168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks @Xia-Weiwen , can you help move these two int4 tensors as well:

int4_opaque_tensor.py and int4_plain_int32_tensor.py

@jerryzh168
Copy link
Contributor

@Xia-Weiwen if you mark this as bc-breaking, you'll need to write a bc-breaking note

I think it's fine to skip as well since it's probably not widely used yet since it's relatively new, but adding a bc-breaking note sounds fine as well.

@Xia-Weiwen
Copy link
Collaborator Author

@Xia-Weiwen if you mark this as bc-breaking, you'll need to write a bc-breaking note

I think it's fine to skip as well since it's probably not widely used yet since it's relatively new, but adding a bc-breaking note sounds fine as well.

Thanks for the heads up. To make things easier, let me just change the label to "not user facing".

@Xia-Weiwen Xia-Weiwen added topic: not user facing Use this tag if you don't want this PR to show up in release notes and removed topic: bc-breaking Use this tag if this PR breaks backward compatibility labels Nov 24, 2025
@Xia-Weiwen Xia-Weiwen merged commit 6adb8b8 into pytorch:main Nov 24, 2025
25 of 26 checks passed
@Xia-Weiwen
Copy link
Collaborator Author

looks great, thanks @Xia-Weiwen , can you help move these two int4 tensors as well:

int4_opaque_tensor.py and int4_plain_int32_tensor.py

Sure.

@Xia-Weiwen
Copy link
Collaborator Author

looks great, thanks @Xia-Weiwen , can you help move these two int4 tensors as well:

int4_opaque_tensor.py and int4_plain_int32_tensor.py

Hi @liangan1 Could you please take int4_plain_int32_tensor.py ? Thanks.

@liangan1
Copy link
Collaborator

@jerryzh168 int4 for xpu should be some mature features, I am not sure why we need to move it into the prototype? int4_plain_int32_tensor.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants