Skip to content

[ET-VK][ez][testing] Remove conv2d test in compute_api_test + reduce stdout logging #11452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: gh/SS-JIA/238/base
Choose a base branch
from

Conversation

SS-JIA
Copy link
Contributor

@SS-JIA SS-JIA commented Jun 6, 2025

Stack from ghstack (oldest at bottom):

Changes

Some changes to vulkan_compute_api_test:

  • Remove conv2d_prepack_test. D74523774 / [ET-VK] Using push constants for convolution prepack dispatches. #11306 recently changed the conv2d prepack shader to use push constants, and since this test uses the "old" vulkan compute API (which doesn't support push constants) the test broke. Operator tests at this point are handled by compute_graph_op_tests anyway so just remove this test.
  • Make it so that verbose logging in test_to_copy only occurs in VULKAN_DEBUG is defined
  • Disable test_etvk_copy_channel_offset_node* tests, as these tests fail on some platforms (i.e. devGPU, windows, mac) likely due to an error in the implementation of the op.

Differential Revision: D76156109

…stdout logging

## Changes

Some changes to `vulkan_compute_api_test`:

* Remove `conv2d_prepack_test`. D74523774 / #11306 recently changed the conv2d prepack shader to use push constants, and since this test uses the "old" vulkan compute API (which doesn't support push constants) the test broke. Operator tests at this point are handled by `compute_graph_op_tests` anyway so just remove this test.
* Make it so that verbose logging in `test_to_copy` only occurs in `VULKAN_DEBUG` is defined
* Disable `test_etvk_copy_channel_offset_node*` tests, as these tests fail on some platforms (i.e. devGPU, windows, mac) likely due to an error in the implementation of the op.

Differential Revision: [D76156109](https://our.internmc.facebook.com/intern/diff/D76156109/)

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Jun 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11452

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 65fe4ef with merge base 27cb43d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 6, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76156109

Copy link

github-actions bot commented Jun 6, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

…t + reduce stdout logging"

## Changes

Some changes to `vulkan_compute_api_test`:

* Remove `conv2d_prepack_test`. D74523774 / #11306 recently changed the conv2d prepack shader to use push constants, and since this test uses the "old" vulkan compute API (which doesn't support push constants) the test broke. Operator tests at this point are handled by `compute_graph_op_tests` anyway so just remove this test.
* Make it so that verbose logging in `test_to_copy` only occurs in `VULKAN_DEBUG` is defined
* Disable `test_etvk_copy_channel_offset_node*` tests, as these tests fail on some platforms (i.e. devGPU, windows, mac) likely due to an error in the implementation of the op.

Differential Revision: [D76156109](https://our.internmc.facebook.com/intern/diff/D76156109/)

[ghstack-poisoned]
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76156109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants