[5.1/ N] set_option/get_option API with {backend_name, backend options} only #11865
+185
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s} only
This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR
Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too
Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
[ghstack-poisoned]
This was referenced Jun 23, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11865
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 441f673 with merge base 222d9e3 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
cccclai
added a commit
that referenced
this pull request
Jun 23, 2025
…s} only
This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR
Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too
Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
ghstack-source-id: 292211297
Pull Request resolved: #11865
|
This pull request was exported from Phabricator. Differential Revision: D77190316 |
…kend options} only"
This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR
Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too
Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
[ghstack-poisoned]
cccclai
added a commit
that referenced
this pull request
Jun 24, 2025
…s} only Pull Request resolved: #11865 This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too ghstack-source-id: 292211297 Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
|
This pull request was exported from Phabricator. Differential Revision: D77190316 |
…kend options} only"
This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR
Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too
Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
[ghstack-poisoned]
cccclai
added a commit
that referenced
this pull request
Jun 24, 2025
…s} only Pull Request resolved: #11865 This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too ghstack-source-id: 292211297 Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
…kend options} only"
This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR
Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too
Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
[ghstack-poisoned]
cccclai
added a commit
that referenced
this pull request
Jun 24, 2025
…s} only Pull Request resolved: #11865 This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too ghstack-source-id: 292211297 Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
kimishpatel
approved these changes
Jun 24, 2025
…kend options} only"
This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR
Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too
Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
[ghstack-poisoned]
cccclai
added a commit
that referenced
this pull request
Jun 24, 2025
…s} only Pull Request resolved: #11865 This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too ghstack-source-id: 292250319 Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
|
This pull request was exported from Phabricator. Differential Revision: D77190316 |
…kend options} only"
This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR
Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too
Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
[ghstack-poisoned]
cccclai
added a commit
that referenced
this pull request
Jun 24, 2025
…s} only Pull Request resolved: #11865 This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too ghstack-source-id: 292255640 Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
…kend options} only"
This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR
Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too
Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
[ghstack-poisoned]
cccclai
added a commit
that referenced
this pull request
Jun 24, 2025
…s} only Pull Request resolved: #11865 This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too ghstack-source-id: 292257887 Differential Revision: [D77190316](https://our.internmc.facebook.com/intern/diff/D77190316/)
|
This pull request was exported from Phabricator. Differential Revision: D77190316 |
facebook-github-bot
merged commit 6e46c9d
into
gh/cccclai/31/base
95 of 98 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
cccclai
added
the
release notes: api
cccclai
added a commit
that referenced
this pull request
Jun 24, 2025
…s} only (#11877) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #11865 by @cccclai ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/cccclai/31/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/cccclai/31/head Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/cccclai/23/orig Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/cccclai/31/orig @diff-train-skip-merge --------- Co-authored-by: Chen Lai <[email protected]> Co-authored-by: cccclai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This PR only expose the set_option/get_option API via the pair {backend_name, backend_options}, without necessarily backend options map. The backend options map and it's corresponding API will be exposed to another PR
Reference PR in #11758 which exposes the set_option/get_option with backendoptions map too
Differential Revision: D77190316