Skip to content

Add unique method ID #12692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GregoryComer
Copy link
Member

Summary: Add an auto-incremented identifier field to the Method class and pass into BackendInitContext. This allows backends to disambiguated between methods with the same name (two models with a "forward" method, for example).

Differential Revision: D78697798

Copy link

pytorch-bot bot commented Jul 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12692

Note: Links to docs will display an error until the docs builds have been completed.

❌ 5 New Failures

As of commit 08fa039 with merge base 413dee4 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 21, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78697798

@GregoryComer GregoryComer added the release notes: none Do not include this in the release notes label Jul 21, 2025
@cccclai
Copy link
Contributor

cccclai commented Jul 21, 2025

Is it for weight sharing in xnnpack? Can we use the delegate blob hash instead?

Summary:

Add an auto-incremented identifier field to the Method class and pass into BackendInitContext. This allows backends to disambiguated between methods with the same name (two models with a "forward" method, for example).

Differential Revision: D78697798
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78697798

@GregoryComer GregoryComer requested a review from mcr229 July 21, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants