Skip to content

Check for buffer overflow in prim_ops::et_copy_index() #12697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 24, 2025
Merged

Check for buffer overflow in prim_ops::et_copy_index() #12697

merged 3 commits into from
Jul 24, 2025

Conversation

lucylq
Copy link
Contributor

@lucylq lucylq commented Jul 22, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

^
Test on top of D78676341.

Differential Revision: D78701418

@lucylq
Check for buffer overflow in prim_ops::et_copy_index()
20691f1 
^
Test on top of D78676341.

Differential Revision: [D78701418](https://our.internmc.facebook.com/intern/diff/D78701418/)

[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 22, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12697

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 3ce7f72 with merge base e4bc149 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 22, 2025
This was referenced Jul 22, 2025
Open
Merged
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78701418

@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@lucylq
Update on "Check for buffer overflow in prim_ops::et_copy_index()"
59816a2 
^
Test on top of D78676341.

Differential Revision: [D78701418](https://our.internmc.facebook.com/intern/diff/D78701418/)

[ghstack-poisoned]
lucylq added a commit that referenced this pull request Jul 22, 2025
@lucylq
Check for buffer overflow in prim_ops::et_copy_index()
7aeebc6 
Pull Request resolved: #12697

^
Test on top of D78676341.
ghstack-source-id: 297836250
@exported-using-ghexport

Differential Revision: [D78701418](https://our.internmc.facebook.com/intern/diff/D78701418/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78701418

@lucylq
Update on "Check for buffer overflow in prim_ops::et_copy_index()"
3ce7f72 
^
Test on top of D78676341.

Differential Revision: [D78701418](https://our.internmc.facebook.com/intern/diff/D78701418/)

[ghstack-poisoned]
lucylq added a commit that referenced this pull request Jul 23, 2025
@lucylq
Check for buffer overflow in prim_ops::et_copy_index()
c5c0457 
Pull Request resolved: #12697

^
Test on top of D78676341.
ghstack-source-id: 298161226
@exported-using-ghexport

Differential Revision: [D78701418](https://our.internmc.facebook.com/intern/diff/D78701418/)
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78701418

@facebook-github-bot facebook-github-bot merged commit ede8249 into gh/lucylq/94/base Jul 24, 2025
100 of 102 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/lucylq/94/head branch July 24, 2025 18:28
@pytorchbot pytorchbot mentioned this pull request Jul 24, 2025
Open
@lucylq
Copy link
Contributor Author

lucylq commented Jul 24, 2025

@pytorchbot cherry-pick --onto release/0.7 -c critical

pytorchbot pushed a commit that referenced this pull request Jul 24, 2025
@lucylq @pytorchbot
Check for buffer overflow in prim_ops::et_copy_index()
0a130f3 
Differential Revision: D78701418

Pull Request resolved: #12697

(cherry picked from commit ede8249)
@pytorchbot pytorchbot mentioned this pull request Jul 24, 2025
Open
@pytorchbot
Copy link
Collaborator

Cherry picking #12697

The cherry pick PR is at #12827 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

This was referenced Jul 24, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swolchok swolchok swolchok approved these changes

@manuelcandales manuelcandales Awaiting requested review from manuelcandales manuelcandales is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lucylq @facebook-github-bot @pytorchbot @swolchok