Skip to content

Use Q_ANNOTATION_KEY #12728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use Q_ANNOTATION_KEY #12728

wants to merge 1 commit into from

Conversation

cccclai
Copy link
Contributor

@cccclai cccclai commented Jul 22, 2025

Summary: pytorch/ao#2525 introduced Q_ANNOTATION_KEY to avoid manually typing "quantization_annotation". Trying to apply it in our codebase

Reviewed By: jerryzh168

Differential Revision: D78193037

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 22, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12728

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure

As of commit 62886b8 with merge base 727937e (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 22, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78193037

@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Jul 22, 2025
@cccclai @facebook-github-bot
Use Q_ANNOTATION_KEY (pytorch#12728)
15eecbd 
Summary:

pytorch/ao#2525 introduced Q_ANNOTATION_KEY to avoid manually typing "quantization_annotation". Trying to apply it in our codebase

Reviewed By: jerryzh168

Differential Revision: D78193037
@cccclai cccclai force-pushed the export-D78193037 branch from b9d6de8 to 15eecbd Compare July 22, 2025 23:49
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78193037

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Jul 22, 2025
@cccclai @facebook-github-bot
Use Q_ANNOTATION_KEY (pytorch#12728)
684fbdc 
Summary:
Pull Request resolved: pytorch#12728

pytorch/ao#2525 introduced Q_ANNOTATION_KEY to avoid manually typing "quantization_annotation". Trying to apply it in our codebase

Reviewed By: jerryzh168

Differential Revision: D78193037
@cccclai cccclai force-pushed the export-D78193037 branch from 15eecbd to 684fbdc Compare July 22, 2025 23:53
@cccclai @facebook-github-bot
Use Q_ANNOTATION_KEY (pytorch#12728)
62886b8 
Summary:

pytorch/ao#2525 introduced Q_ANNOTATION_KEY to avoid manually typing "quantization_annotation". Trying to apply it in our codebase

Reviewed By: jerryzh168

Differential Revision: D78193037
@cccclai cccclai force-pushed the export-D78193037 branch from 684fbdc to 62886b8 Compare July 23, 2025 01:21
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78193037

@cccclai cccclai requested a review from jerryzh168 July 23, 2025 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

@mcr229 mcr229 Awaiting requested review from mcr229 mcr229 is a code owner

@kimishpatel kimishpatel Awaiting requested review from kimishpatel kimishpatel is a code owner

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka is a code owner

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@jerryzh168 jerryzh168 Awaiting requested review from jerryzh168

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cccclai @facebook-github-bot