Skip to content

Static attention: support overriding RMSNorm class #12833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2025
Merged

Static attention: support overriding RMSNorm class #12833

merged 1 commit into from
Jul 25, 2025

Conversation

sxu
Copy link
Contributor

@sxu sxu commented Jul 24, 2025

Summary: CoreML backend should not use the default torch.nn.RMSNorm because it leads to worse precision, where as QNN backend should as it leads to a single operator that's more efficient. Support overriding the normalization layer class.

Differential Revision: D78926603

@sxu sxu requested review from lucylq and jackzhxng as code owners July 24, 2025 21:50
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 24, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12833

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 09746d6 with merge base f332196 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 24, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78926603

@sxu sxu requested review from billmguo and YIWENX14 July 24, 2025 21:51
@github-actions GitHub Actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@sxu @facebook-github-bot
Static attention: support overriding RMSNorm class (pytorch#12833)
09746d6 
Summary:

CoreML backend should not use the default torch.nn.RMSNorm because it leads to worse precision, where as QNN backend should as it leads to a single operator that's more efficient. Support overriding the normalization layer class.

Reviewed By: YIWENX14, billmguo

Differential Revision: D78926603
@sxu sxu force-pushed the export-D78926603 branch from 0432fe2 to 09746d6 Compare July 25, 2025 17:17
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D78926603

@facebook-github-bot facebook-github-bot merged commit 0211a03 into pytorch:main Jul 25, 2025
99 of 101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billmguo billmguo billmguo approved these changes

@YIWENX14 YIWENX14 YIWENX14 approved these changes

@lucylq lucylq Awaiting requested review from lucylq lucylq is a code owner

@jackzhxng jackzhxng Awaiting requested review from jackzhxng jackzhxng is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sxu @facebook-github-bot @billmguo @YIWENX14