Skip to content

Add error logging to scripts/print_exported_headers #13686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: gh/swolchok/560/head
Choose a base branch
from
Open

Add error logging to scripts/print_exported_headers #13686

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a4c8303
Update
swolchok Aug 26, 2025
4c4e34b
use python they said, no more compiler errors they said
swolchok Aug 26, 2025
49b0604
Update
swolchok Sep 2, 2025
3c75a2d
try printing to stderr
swolchok Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion scripts/print_exported_headers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
import json
import os
import subprocess
import sys
from typing import List, Set

# Run buck2 from the same directory (and thus repo) as this script.
Expand All @@ -22,7 +23,14 @@

def run(command: List[str]) -> str:
"""Run subprocess and return its output."""
result = subprocess.run(command, capture_output=True, check=True, cwd=BUCK_CWD)
try:
result = subprocess.run(command, capture_output=True, check=True, cwd=BUCK_CWD)
except subprocess.CalledProcessError as ex:
print(
f"Subprocess failed. stdout: {ex.stdout}\nstderr: {ex.stderr}",
file=sys.stderr,
)
raise
return result.stdout.decode()


Expand Down
Loading