Skip to content

Conversation

GregoryComer
Copy link
Member

@GregoryComer GregoryComer commented Aug 26, 2025

The Windows CI build job was disabled in #13669 due to a new Windows build failure in #13485. Since that diff was reverted in #13685, we can re-enable the job.

I started fixing the issue in #13672, but dropped it due to the revert. It's a simple change, so it can likely be bundled when the affected PR is re-landed.

Test Plan:
The Build Preset / Windows job is passing on this PR.

[ghstack-poisoned]
@GregoryComer
Copy link
Member Author

GregoryComer commented Aug 26, 2025

Stack from ghstack (oldest at bottom):

Copy link

pytorch-bot bot commented Aug 26, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13699

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 99 Pending

As of commit 18f4ad6 with merge base 130cafc (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

GregoryComer added a commit that referenced this pull request Aug 26, 2025
ghstack-source-id: 07b0158
ghstack-comment-id: 3225922167
Pull-Request: #13699
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 26, 2025
@GregoryComer GregoryComer added the release notes: none Do not include this in the release notes label Aug 26, 2025
@GregoryComer GregoryComer merged commit 034ff5d into main Aug 26, 2025
112 of 121 checks passed
@GregoryComer GregoryComer deleted the gh/GregoryComer/143/head branch August 26, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants