Skip to content

[ET][Metal] Update aoti_common with additional AOTI functions needed by Metal backend #15003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2025
Merged

[ET][Metal] Update aoti_common with additional AOTI functions needed by Metal backend #15003

merged 2 commits into from
Oct 13, 2025
+36 −0

Conversation

manuelcandales
Copy link
Contributor

@manuelcandales manuelcandales commented Oct 10, 2025 •
edited
Loading

No description provided.

@manuelcandales
Update
6420712 
[ghstack-poisoned]
@manuelcandales
Copy link
Contributor Author

manuelcandales commented Oct 10, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

manuelcandales added a commit that referenced this pull request Oct 10, 2025
@manuelcandales
[ET][Metal] Update aoti_common with additional AOTI functions needed …
6954fdf 
…by Metal backend

ghstack-source-id: f11bbd0
ghstack-comment-id: 3391401077
Pull-Request: #15003
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 10, 2025
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 10, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15003

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

⏳ No Failures, 122 Pending

As of commit c4c16aa with merge base d00279d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@manuelcandales manuelcandales added the release notes: none Do not include this in the release notes label Oct 10, 2025
@manuelcandales manuelcandales mentioned this pull request Oct 10, 2025
Open
This was referenced Oct 10, 2025
Open
Open
Open
Open
Open
Open
mergennachin
mergennachin reviewed Oct 12, 2025
View reviewed changes
Copy link
Contributor

@mergennachin mergennachin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comment. Instead of saying "Needed by Metal backend", let's just properly document the methods.

mergennachin
mergennachin approved these changes Oct 12, 2025
View reviewed changes
Copy link
Contributor

@mergennachin mergennachin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my previous comment

@manuelcandales
Update
c4c16aa 
[ghstack-poisoned]
@manuelcandales manuelcandales merged commit f84c423 into main Oct 13, 2025
122 of 131 checks passed
@manuelcandales manuelcandales deleted the gh/manuelcandales/137/head branch October 13, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mergennachin mergennachin mergennachin approved these changes

@Gasoonjia Gasoonjia Awaiting requested review from Gasoonjia

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@manuelcandales @mergennachin