Skip to content

Conversation

@Ninja91
Copy link
Contributor

@Ninja91 Ninja91 commented Nov 6, 2025

Summary:
Fix Rsqrt op for int16
Relands D83802158

Differential Revision: D86402524

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

@Ninja91 Ninja91 requested a review from digantdesai as a code owner November 6, 2025 09:57
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15631

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 3 Unrelated Failures

As of commit 9691954 with merge base 3dbc15b (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 6, 2025
@meta-codesync
Copy link

meta-codesync bot commented Nov 6, 2025

@Ninja91 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86402524.

@Ninja91 Ninja91 requested review from SaoirseARM and gggekov November 6, 2025 09:58
@zingo zingo added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate ciflow/trunk labels Nov 6, 2025
Ninja91 added a commit to Ninja91/executorch that referenced this pull request Nov 6, 2025
Summary:

Fix Rsqrt op for int16
Relands D83802158

Differential Revision: D86402524
@Ninja91 Ninja91 requested a review from zingo November 6, 2025 16:57
@Ninja91
Copy link
Contributor Author

Ninja91 commented Nov 6, 2025

test-lama-runner-mac test seemes unrrelated.
cc: @zingo @digantdesai @SaoirseARM

Ninja91 added a commit to Ninja91/executorch that referenced this pull request Nov 7, 2025
Summary:

Fix Rsqrt op for int16
Relands D83802158

Differential Revision: D86402524
@zingo
Copy link
Collaborator

zingo commented Nov 7, 2025

Hi @Ninja91 this is the fails we see,

pull / unittest-arm-backend-with-no-fvp (test_pytest_ops) / linux-job (pull_request)
FAILED backends/arm/test/ops/test_rsqrt.py::test_rsqrt_int16_tosa_INT[rand_4d_1]
FAILED backends/arm/test/ops/test_rsqrt.py::test_rsqrt_int16_tosa_INT[rand_4d_2]
FAILED backends/arm/test/ops/test_rsqrt.py::test_rsqrt_int16_tosa_INT[rand_3d]

if you can break out the fails in it's own tests you can add a tag
@pytest.mark.xfail( reason="text" )
for now, or just commen them out.

Also we see #14770 should that be closed?

Ninja91 added a commit to Ninja91/executorch that referenced this pull request Nov 7, 2025
Summary:

Fix Rsqrt op for int16
Relands D83802158

Some TOSA INT16 tests are successful internally but failing in OSS. Marking them with xfail.
https://hud.pytorch.org/pr/pytorch/executorch/15631#54772221446

Differential Revision: D86402524
Ninja91 added a commit to Ninja91/executorch that referenced this pull request Nov 7, 2025
Summary:

Fix Rsqrt op for int16
Relands D83802158

Some TOSA INT16 tests are successful internally but failing in OSS. Marking them with xfail.
https://hud.pytorch.org/pr/pytorch/executorch/15631#54772221446

Differential Revision: D86402524
@Ninja91 Ninja91 requested a review from zingo November 7, 2025 16:49
@zingo
Copy link
Collaborator

zingo commented Nov 7, 2025

Thanks for the update, lets see if CI passes now.

Maybe we want/need to carve out just the failed tests and only mark those but lets see, we should probably add atol/rtol instead and remove xfails long term anyway so if CI is happy I'm happy :)

@zingo zingo changed the title Add tests for int16 rsqrt on Ethos-U55/U85 Arm backend: Add tests for int16 rsqrt on Ethos-U55/U85 Nov 7, 2025
@zingo
Copy link
Collaborator

zingo commented Nov 7, 2025

@Ninja91 I see
Meta Internal-Only Changes Check — The Diff and Pull Request are not in sync!

It stops me from merging, I don't know if it's bacause I edited the commit heade adding "Arm backend: " Maybe you need to reimport it or something else? Sorry about that.

@zingo zingo changed the title Arm backend: Add tests for int16 rsqrt on Ethos-U55/U85 Add tests for int16 rsqrt on Ethos-U55/U85 Nov 7, 2025
@zingo zingo changed the title Add tests for int16 rsqrt on Ethos-U55/U85 Arm backend: Add tests for int16 rsqrt on Ethos-U55/U85 Nov 7, 2025
Summary:

Fix Rsqrt op for int16
Relands D83802158

Some TOSA INT16 tests are successful internally but failing in OSS. Marking them with xfail.
https://hud.pytorch.org/pr/pytorch/executorch/15631#54772221446

Differential Revision: D86402524
@limintang limintang self-requested a review November 7, 2025 17:59
@zingo
Copy link
Collaborator

zingo commented Nov 7, 2025

Arm Backend Fail
FAILED backends/arm/test/ops/test_sub.py::test_sub_tensor_tosa_INT_alpha[rand_4D_pi]
is unrelated and has a error rate on about 2-3% normaly we should retrigger to prove it but due to this is needed to be merged Ill just state it here this time.
Rest of the fails are also unrelated

@zingo zingo merged commit 24c6961 into pytorch:main Nov 7, 2025
517 of 531 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants