-
Notifications
You must be signed in to change notification settings - Fork 713
Arm backend: Add tests for int16 rsqrt on Ethos-U55/U85 #15631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15631
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 3 Unrelated FailuresAs of commit 9691954 with merge base 3dbc15b ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
16a0d9b to
0f1b220
Compare
Summary: Fix Rsqrt op for int16 Relands D83802158 Differential Revision: D86402524
|
test-lama-runner-mac test seemes unrrelated. |
0f1b220 to
8280e33
Compare
Summary: Fix Rsqrt op for int16 Relands D83802158 Differential Revision: D86402524
|
Hi @Ninja91 this is the fails we see, pull / unittest-arm-backend-with-no-fvp (test_pytest_ops) / linux-job (pull_request) if you can break out the fails in it's own tests you can add a tag Also we see #14770 should that be closed? |
Summary: Fix Rsqrt op for int16 Relands D83802158 Some TOSA INT16 tests are successful internally but failing in OSS. Marking them with xfail. https://hud.pytorch.org/pr/pytorch/executorch/15631#54772221446 Differential Revision: D86402524
8280e33 to
797e654
Compare
Summary: Fix Rsqrt op for int16 Relands D83802158 Some TOSA INT16 tests are successful internally but failing in OSS. Marking them with xfail. https://hud.pytorch.org/pr/pytorch/executorch/15631#54772221446 Differential Revision: D86402524
797e654 to
47ef487
Compare
|
Thanks for the update, lets see if CI passes now. Maybe we want/need to carve out just the failed tests and only mark those but lets see, we should probably add atol/rtol instead and remove xfails long term anyway so if CI is happy I'm happy :) |
|
@Ninja91 I see It stops me from merging, I don't know if it's bacause I edited the commit heade adding "Arm backend: " Maybe you need to reimport it or something else? Sorry about that. |
Summary: Fix Rsqrt op for int16 Relands D83802158 Some TOSA INT16 tests are successful internally but failing in OSS. Marking them with xfail. https://hud.pytorch.org/pr/pytorch/executorch/15631#54772221446 Differential Revision: D86402524
47ef487 to
9691954
Compare
|
Arm Backend Fail |
Summary:
Fix Rsqrt op for int16
Relands D83802158
Differential Revision: D86402524
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai