Using push constants for binary scalar op parameter. #16114
+8
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16114
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 5cba711 with merge base 488d761 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
@trivedivivek has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88097606. |
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Dec 5, 2025
Summary: The diff modifies the `BinaryScalarOp` implementation to utilize push constants for the scalar value parameter. Differential Revision: D88097606
trivedivivek
added
the
release notes: vulkan
yipjustin
approved these changes
Dec 5, 2025
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Dec 8, 2025
Summary: The diff modifies the `BinaryScalarOp` implementation to utilize push constants for the scalar value parameter. Reviewed By: yipjustin Differential Revision: D88097606
trivedivivek
force-pushed
the
export-D88097606
branch
from
13fa93a to
b9df88c
Compare
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Dec 8, 2025
Summary: The diff modifies the `BinaryScalarOp` implementation to utilize push constants for the scalar value parameter. Reviewed By: yipjustin Differential Revision: D88097606
trivedivivek
force-pushed
the
export-D88097606
branch
from
b9df88c to
749fce9
Compare
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Dec 8, 2025
Summary: The diff modifies the `BinaryScalarOp` implementation to utilize push constants for the scalar value parameter. Reviewed By: yipjustin Differential Revision: D88097606
trivedivivek
force-pushed
the
export-D88097606
branch
from
749fce9 to
92a3f2d
Compare
trivedivivek
added a commit
to trivedivivek/executorch
that referenced
this pull request
Dec 8, 2025
Summary: The diff modifies the `BinaryScalarOp` implementation to utilize push constants for the scalar value parameter. Reviewed By: yipjustin Differential Revision: D88097606
trivedivivek
force-pushed
the
export-D88097606
branch
from
92a3f2d to
059bf4f
Compare
Summary: The diff modifies the `BinaryScalarOp` implementation to utilize push constants for the scalar value parameter. Reviewed By: yipjustin Differential Revision: D88097606
trivedivivek
force-pushed
the
export-D88097606
branch
from
059bf4f to
5cba711
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The diff modifies the
BinaryScalarOpimplementation to utilize push constants for the scalar value parameter.Differential Revision: D88097606