remove pybind usage, make example python agnostic #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zou3519
approved these changes
Jan 21, 2025
janeyx99
force-pushed
the
python-agnostic
branch
from
59d25ad to
e4c4eb8
Compare
|
Will merge if CI passes |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use torch.ops.load_library instead of PYBIND11 to allow the extension to be python agnostic.
This is step 1 in modernizing the user story for cpp extensions. Step 2 is to change the corresponding tutorial.
I also have yet to test locally that this is indeed python agnostic.Now I've tested locally that the wheel works for 3.10 and 3.13 (when built on 3.13)
Other steps done in:
#106, #108
#107