Add call function to triton output for easier repros #514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oulgen
added a commit
that referenced
this pull request
Aug 22, 2025
stack-info: PR: #514, branch: oulgen/stack/64
oulgen
force-pushed
the
oulgen/stack/64
branch
from
240087e to
8c4888b
Compare
meta-cla
bot
added
the
CLA Signed
oulgen
added a commit
that referenced
this pull request
Aug 22, 2025
stack-info: PR: #514, branch: oulgen/stack/64
oulgen
force-pushed
the
oulgen/stack/64
branch
from
8c4888b to
4ce5098
Compare
yf225
reviewed
Aug 22, 2025
helion/runtime/settings.py
Outdated
| @@ -87,6 +87,7 @@ class _Settings: | |||
| ) | |||
| autotune_precompile: bool = sys.platform != "win32" | |||
| print_output_code: bool = os.environ.get("HELION_PRINT_OUTPUT_CODE", "0") == "1" | |||
| print_triton_repro: bool = os.environ.get("HELION_PRINT_TRITON_REPRO", "0") == "1" | |||
There was a problem hiding this comment.
Wonder should HELION_PRINT_OUTPUT_CODE=1 just also print the call function? That way we might be able to save one environment variable too.
oulgen
added a commit
that referenced
this pull request
Aug 22, 2025
stack-info: PR: #514, branch: oulgen/stack/64
oulgen
force-pushed
the
oulgen/stack/64
branch
from
4ce5098 to
4fe855e
Compare
oulgen
added a commit
that referenced
this pull request
Aug 22, 2025
stack-info: PR: #514, branch: oulgen/stack/64
oulgen
force-pushed
the
oulgen/stack/64
branch
from
4fe855e to
86ee59c
Compare
stack-info: PR: #514, branch: oulgen/stack/64
oulgen
force-pushed
the
oulgen/stack/64
branch
from
86ee59c to
5e80982
Compare
jansel
requested changes
Aug 25, 2025
Comment on lines
+257
to
+262
| if isinstance(arg, torch.SymInt): | ||
| rhs = int(arg) | ||
| elif isinstance(arg, torch.SymFloat): | ||
| rhs = float(arg) | ||
| elif isinstance(arg, torch.SymBool): | ||
| rhs = bool(arg) |
There was a problem hiding this comment.
Do we need to be using size hints here? SymInt.__int__ adds a guard implicitly which might create some weirdness in the shape env?
There was a problem hiding this comment.
What would be the alternative if I want to convert a symint to a representative integer?
There was a problem hiding this comment.
I think there is a helper to get the size hint (without adding a guard) in CompileEnvironment/shape env.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
Add call function to triton output for easier repros