Skip to content

Conversation

williamwen42
Copy link
Member

#802 but without ghstack

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 3, 2025
Copy link
Contributor

@oulgen oulgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • fix the lint error
  • add the backwards implementation to benchmarks/run.py -- there's a big list, grep for rms_norm
  • add a unit test to test_examples.py

@williamwen42
Copy link
Member Author

@oulgen I had to type a number of my kernel arguments with hl.constexpr instead of the actual types in order to prevent compilation errors, e.g. typing compute_y_true_grad as bool would result in a branch type divergence error; typing eps as float would result in a GuardOnDataDependentSymNode when attempting to compute math.log(eps). Can you advise if there's a more preferred way for me to express the computation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants