Skip to content

Conversation

Sibylau
Copy link
Contributor

@Sibylau Sibylau commented Oct 7, 2025

Stacked PRs:


[Benchmark] template attention kernel and test

stack-info: PR: #824, branch: Sibylau/stack/7
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 7, 2025
@Sibylau
Copy link
Contributor Author

Sibylau commented Oct 7, 2025

tritonbench accuracy check passes:
image

code generation journal check passes:
image

@Sibylau Sibylau requested review from yf225 and oulgen October 7, 2025 20:49
@yf225
Copy link
Contributor

yf225 commented Oct 8, 2025

Thanks! We will probably need to look into the performance side of attention kernels too. The perf of regular attention kernels is currently being worked on, and after it's done we might need to revise the kernel in this PR to match the pattern better. So I'll put it on hold until we get the attention perf work done (should be soon, in preparation for PTC).

@Sibylau
Copy link
Contributor Author

Sibylau commented Oct 8, 2025

Thanks! We will probably need to look into the performance side of attention kernels too. The perf of regular attention kernels is currently being worked on, and after it's done we might need to revise the kernel in this PR to match the pattern better. So I'll put it on hold until we get the attention perf work done (should be soon, in preparation for PTC).

Thank you! Happy to help revise the kernel to match performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants