Skip to content

Conversation

yf225
Copy link
Contributor

@yf225 yf225 commented Oct 8, 2025

Fixes #686.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 8, 2025
@jansel
Copy link
Contributor

jansel commented Oct 8, 2025

We also have @helion.kernel(index_dtype=torch.int64). It might be better to error and force people to provide that annotation. Otherwise, you might get a different kernel based on the size hints of the inputs, and I don't think we will automatically recompile if you run first with a small size then a large one.

@yf225 yf225 force-pushed the add_kernel_ima_fix branch 12 times, most recently from 681e224 to 7381a92 Compare October 9, 2025 03:28
@yf225 yf225 force-pushed the add_kernel_ima_fix branch from 7381a92 to b317f03 Compare October 9, 2025 17:32
@yf225 yf225 changed the title Convert index dtype to int64 if out of bound for int32 Suggest use of @helion.kernel(index_dtype=torch.int64) if index offset is out of bound for int32 Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IMA on default config of add kernel

2 participants