Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special Functions (WIP) #48

Draft
wants to merge 109 commits into
base: master
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
109 commits
Select commit Hold shift + click to select a range
424ee1c
Update RFC-00xx-special-functions.md
0x00b1 Oct 10, 2022
6ace7e7
Update RFC-00xx-special-functions.md
0x00b1 Nov 1, 2022
6b4edfe
Update RFC-00xx-special-functions.md
0x00b1 Nov 1, 2022
9c39c44
Update RFC-00xx-special-functions.md
0x00b1 Nov 1, 2022
0b7ac7c
Update RFC-00xx-special-functions.md
0x00b1 Nov 1, 2022
b5fa55d
Update RFC-00xx-special-functions.md
0x00b1 Nov 1, 2022
60fa130
Update RFC-00xx-special-functions.md
0x00b1 Nov 1, 2022
498e1f8
Update RFC-00xx-special-functions.md
0x00b1 Nov 1, 2022
220b9ae
Update RFC-00xx-special-functions.md
0x00b1 Nov 1, 2022
cb4f3a6
Update RFC-00xx-special-functions.md
0x00b1 Nov 1, 2022
ed359b4
Update RFC-00xx-special-functions.md
0x00b1 Nov 1, 2022
9d80cf4
Update RFC-00xx-special-functions.md
0x00b1 Nov 1, 2022
649aca3
Update RFC-00xx-special-functions.md
0x00b1 Nov 1, 2022
17b128e
Update RFC-00xx-special-functions.md
0x00b1 Nov 1, 2022
998f6c2
Update RFC-00xx-special-functions.md
0x00b1 Nov 1, 2022
5359b12
Update RFC-00xx-special-functions.md
0x00b1 Nov 1, 2022
fe4511d
Update RFC-00xx-special-functions.md
0x00b1 Nov 1, 2022
ea05803
Update RFC-00xx-special-functions.md
0x00b1 Nov 1, 2022
48f2112
Update RFC-00xx-special-functions.md
0x00b1 Nov 1, 2022
ac536f5
Update RFC-00xx-special-functions.md
0x00b1 Nov 1, 2022
1a19860
Update RFC-00xx-special-functions.md
0x00b1 Nov 1, 2022
72d4550
Update RFC-00xx-special-functions.md
0x00b1 Nov 1, 2022
18c4fa2
Update RFC-00xx-special-functions.md
0x00b1 Nov 1, 2022
217714b
Update RFC-00xx-special-functions.md
0x00b1 Nov 1, 2022
7105ef1
Update RFC-00xx-special-functions.md
0x00b1 Nov 1, 2022
59c6f0f
Update RFC-00xx-special-functions.md
0x00b1 Nov 1, 2022
8c3e3f2
Update RFC-00xx-special-functions.md
0x00b1 Nov 1, 2022
8ac9599
Update RFC-00xx-special-functions.md
0x00b1 Oct 10, 2022
ac9b441
Update RFC-00xx-special-functions.md
0x00b1 Nov 1, 2022
093699a
Update RFC-00xx-special-functions.md
0x00b1 Nov 1, 2022
9ba84ce
Update RFC-00xx-special-functions.md
0x00b1 Nov 1, 2022
7453c43
Update RFC-00xx-special-functions.md
0x00b1 Nov 1, 2022
5c6d1c0
Merge branch 'special-functions' of https://github.com/0x00b1/rfcs in…
0x00b1 Nov 1, 2022
f50b2a0
Update RFC-00xx-special-functions.md
0x00b1 Nov 1, 2022
dffaf5e
Update RFC-00xx-special-functions.md
0x00b1 Nov 4, 2022
da665d9
Update RFC-00xx-special-functions.md
0x00b1 Nov 4, 2022
24dbe8f
Update RFC-00xx-special-functions.md
0x00b1 Nov 4, 2022
ab94fdc
Update RFC-00xx-special-functions.md
0x00b1 Nov 4, 2022
dd38d83
Update RFC-00xx-special-functions.md
0x00b1 Nov 4, 2022
913dcc7
Update RFC-00xx-special-functions.md
0x00b1 Nov 4, 2022
8986f8a
Update RFC-00xx-special-functions.md
0x00b1 Nov 4, 2022
c2af690
Update RFC-00xx-special-functions.md
0x00b1 Nov 4, 2022
1ae47cc
Update RFC-00xx-special-functions.md
0x00b1 Nov 4, 2022
08a48a2
Update RFC-00xx-special-functions.md
0x00b1 Nov 4, 2022
b5c28f0
Update RFC-00xx-special-functions.md
0x00b1 Nov 4, 2022
2423bfe
Update RFC-00xx-special-functions.md
0x00b1 Nov 4, 2022
6f66d87
Update RFC-00xx-special-functions.md
0x00b1 Nov 4, 2022
6c93034
Update RFC-00xx-special-functions.md
0x00b1 Nov 4, 2022
c9b727a
Update RFC-00xx-special-functions.md
0x00b1 Nov 4, 2022
7031c34
Update RFC-00xx-special-functions.md
0x00b1 Nov 4, 2022
8c665b7
Update RFC-00xx-special-functions.md
0x00b1 Nov 4, 2022
8aa81c7
Update RFC-00xx-special-functions.md
0x00b1 Nov 4, 2022
f070f16
Update RFC-00xx-special-functions.md
0x00b1 Nov 4, 2022
a0b1657
Update RFC-00xx-special-functions.md
0x00b1 Nov 4, 2022
a2c765e
Update RFC-00xx-special-functions.md
0x00b1 Nov 4, 2022
ebfb221
Update RFC-00xx-special-functions.md
0x00b1 Nov 4, 2022
917ec08
Update RFC-00xx-special-functions.md
0x00b1 Nov 4, 2022
476e80e
Update RFC-00xx-special-functions.md
0x00b1 Nov 4, 2022
5d86a3b
Update RFC-00xx-special-functions.md
0x00b1 Nov 4, 2022
240e378
Update RFC-00xx-special-functions.md
0x00b1 Nov 4, 2022
ed67d6e
Update RFC-00xx-special-functions.md
0x00b1 Nov 4, 2022
978502c
Update RFC-00xx-special-functions.md
0x00b1 Nov 4, 2022
2575ad0
Update RFC-00xx-special-functions.md
0x00b1 Nov 4, 2022
0e950eb
Update RFC-00xx-special-functions.md
0x00b1 Nov 4, 2022
88e6874
Update RFC-00xx-special-functions.md
0x00b1 Nov 4, 2022
1a305f8
Update RFC-00xx-special-functions.md
0x00b1 Nov 6, 2022
459449a
Update RFC-00xx-special-functions.md
0x00b1 Nov 6, 2022
4c9bda7
Update RFC-00xx-special-functions.md
0x00b1 Nov 6, 2022
fcca2c9
Update RFC-00xx-special-functions.md
0x00b1 Nov 6, 2022
b97f420
Update RFC-00xx-special-functions.md
0x00b1 Nov 6, 2022
a231b07
Update RFC-00xx-special-functions.md
0x00b1 Nov 6, 2022
eb4aee6
Update RFC-00xx-special-functions.md
0x00b1 Nov 6, 2022
47c60e3
Update RFC-00xx-special-functions.md
0x00b1 Nov 6, 2022
ae06fee
Update RFC-00xx-special-functions.md
0x00b1 Nov 6, 2022
095c84c
Update RFC-00xx-special-functions.md
0x00b1 Nov 6, 2022
8c6596f
Update RFC-00xx-special-functions.md
0x00b1 Nov 6, 2022
15ed068
Update RFC-00xx-special-functions.md
0x00b1 Nov 6, 2022
448ee88
Update RFC-00xx-special-functions.md
0x00b1 Nov 6, 2022
e6d7638
Update RFC-00xx-special-functions.md
0x00b1 Nov 6, 2022
4fa5579
Update RFC-00xx-special-functions.md
0x00b1 Nov 6, 2022
f33f427
Update RFC-00xx-special-functions.md
0x00b1 Nov 6, 2022
829b15f
Update RFC-00xx-special-functions.md
0x00b1 Nov 6, 2022
ec74536
Update RFC-00xx-special-functions.md
0x00b1 Nov 6, 2022
a0834ba
Update RFC-00xx-special-functions.md
0x00b1 Nov 6, 2022
9257088
Update RFC-00xx-special-functions.md
0x00b1 Nov 6, 2022
49cd3f8
Update RFC-00xx-special-functions.md
0x00b1 Nov 6, 2022
ff47b9b
Update RFC-00xx-special-functions.md
0x00b1 Nov 6, 2022
add70f6
Update RFC-00xx-special-functions.md
0x00b1 Nov 6, 2022
4d806ca
Update RFC-00xx-special-functions.md
0x00b1 Nov 6, 2022
c9b7fd1
Update RFC-00xx-special-functions.md
0x00b1 Nov 6, 2022
71a1165
Update RFC-00xx-special-functions.md
0x00b1 Nov 7, 2022
9856ff1
Update RFC-00xx-special-functions.md
0x00b1 Nov 7, 2022
65afb9b
Update RFC-00xx-special-functions.md
0x00b1 Nov 7, 2022
c9fcf0b
Update RFC-00xx-special-functions.md
0x00b1 Nov 7, 2022
f0c1cf8
Update RFC-00xx-special-functions.md
0x00b1 Nov 7, 2022
08cdf94
Update RFC-00xx-special-functions.md
0x00b1 Nov 7, 2022
5da6a88
Update RFC-00xx-special-functions.md
0x00b1 Nov 7, 2022
61ac0c1
Update RFC-00xx-special-functions.md
0x00b1 Nov 7, 2022
5a20552
Update RFC-00xx-special-functions.md
0x00b1 Nov 7, 2022
a138d3b
Update RFC-00xx-special-functions.md
0x00b1 Nov 7, 2022
5db229c
Update RFC-00xx-special-functions.md
0x00b1 Nov 7, 2022
e376a73
Update RFC-00xx-special-functions.md
0x00b1 Nov 7, 2022
9d6f2fc
Update RFC-00xx-special-functions.md
0x00b1 Nov 7, 2022
8574514
Update RFC-00xx-special-functions.md
0x00b1 Nov 7, 2022
d823193
Update RFC-00xx-special-functions.md
0x00b1 Nov 7, 2022
86c77ea
Update RFC-00xx-special-functions.md
0x00b1 Nov 7, 2022
8f99438
Update RFC-00xx-special-functions.md
0x00b1 Nov 7, 2022
75c0ce1
Update RFC-00xx-special-functions.md
0x00b1 Nov 7, 2022
be2c25f
Update RFC-00xx-special-functions.md
0x00b1 Nov 7, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update RFC-00xx-special-functions.md
0x00b1 committed Nov 1, 2022
commit 8c3e3f2115e7b9cf4a727899ecfcc8abf67b1733
92 changes: 0 additions & 92 deletions RFC-00xx-special-functions.md
Original file line number Diff line number Diff line change
@@ -3549,47 +3549,14 @@ $n^{\text{th}}$ prime number, $p(n)$.

#### Coulomb Wave Function (G)

### 3-j, 6-j, and 9-j Symbols

#### 3-j Symbol

#### 6-j Symbol

#### 9-j Symbol

## Metrics

<details>
What are the main metrics to measure the value of this feature?
</details>

## Drawbacks

<details>
Are there any reasons why we should not do this? Here we aim to evaluate risk and check ourselves.

Please consider:
* is it a breaking change?
* Impact on UX
* implementation cost, both in terms of code size and complexity
* integration of this feature with other existing and planned features
</details>

## Alternatives

<details>
What other designs have been considered? What is the impact of not doing this?
</details>

## Prior Art

<details>
Discuss prior art (both good and bad) in relation to this proposal:
* Does this feature exist in other libraries? What experience has their community had?
* What lessons can be learned from other implementations of this feature?
* Published papers or great posts that discuss this
</details>

### Cephes Mathematical Library

Suite of elementary and special functions written by Stephen L. Moshier. It was initially created as a supplement to his numerical analysis textbook, “Methods and Programs for Mathematical Functions.” Unsure of the original publication date, but I estimate somewhere between 1984 and 1986. It was most recently updated, by Moshier, in 2018. Its use is ubiquitous (it’s even presently used in PyTorch), and DeepMind recently maintained a library wrapper for PyTorch.
@@ -3611,62 +3578,3 @@ General-purpose, commercial, multi-paradigm programming language written and mai
### SciPy

SciPy is a free and open-source Python package for scientific computing. It contains modules for linear algebra, integration, optimization, etc. SciPy also contains a robust suite of special functions. Most of the special function implementations rely on third-party packages, many featured elsewhere in this subsection (e.g., Cephes and specfun).

## How we teach this

<details>
* What names and terminology work best for these concepts and why? How is this idea best presented?
* Would the acceptance of this proposal mean the PyTorch documentation must be re-organized or altered?
* How should this feature be taught to existing PyTorch users?
</details>

## Unresolved questions

<details>
* What parts of the design do you expect to resolve through the RFC process before this gets merged?
* What parts of the design do you expect to resolve through the implementation of this feature before stabilization?
* What related issues do you consider out of scope for this RFC that could be addressed in the future independently of the solution that comes out of this RFC?
</details>

## Resolution

<details>
We decided to do it. X% of the engineering team actively approved of this change.
</details>

### Level of Support

<details>
Choose one of the following:
* 1: Overwhelming positive feedback.
* 2: Positive feedback.
* 3: Majority Acceptance, with conflicting Feedback.
* 4: Acceptance, with Little Feedback.
* 5: Unclear Resolution.
* 6: RFC Rejected.
* 7: RFC Rejected, with Conflicting Feedback.
</details>

#### Additional Context

<details>
Some people were in favor of it, but some people didn’t want it for project X.
</details>

### Next Steps

<details>
Will implement it.
</details>

#### Tracking issue

<details>
<github issue URL>
</details>

#### Exceptions

<details>
Not implementing on project X now. Will revisit the decision in 1 year.
</details>