Skip to content

[Test] Fix flaky tests #3233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

[Test] Fix flaky tests #3233

wants to merge 13 commits into from
+8,153 −6,717

Conversation

@vmoens
Copy link
Collaborator

@vmoens vmoens commented Nov 7, 2025

No description provided.

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 7, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3233

Note: Links to docs will display an error until the docs builds have been completed.

❌ 13 New Failures, 7 Unrelated Failures

As of commit ba39d0a with merge base 3d5dd1a (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 7, 2025
@github-actions
Copy link

github-actions bot commented Nov 7, 2025 •
edited
Loading

$\color{#D29922}\textsf{\Large⚠\kern{0.2cm}\normalsize Warning}$ Result of CPU Benchmark Tests

Total Benchmarks: 154. Improved: $\large\color{#35bf28}11$. Worsened: $\large\color{#d91a1a}7$.

Expand to view detailed results
Name Max Mean Ops Ops on Repo HEAD Change
test_tensor_to_bytestream_speed[pickle] 83.8023μs 82.5631μs 12.1120 KOps/s 12.1089 KOps/s $\color{#35bf28}+0.03\%$
test_tensor_to_bytestream_speed[torch.save] 0.1421ms 0.1416ms 7.0627 KOps/s 7.0913 KOps/s $\color{#d91a1a}-0.40\%$
test_tensor_to_bytestream_speed[untyped_storage] 0.1187s 0.1185s 8.4401 Ops/s 8.5617 Ops/s $\color{#d91a1a}-1.42\%$
test_tensor_to_bytestream_speed[numpy] 2.9717μs 2.9674μs 337.0007 KOps/s 341.4634 KOps/s $\color{#d91a1a}-1.31\%$
test_tensor_to_bytestream_speed[safetensors] 43.0798μs 42.9302μs 23.2936 KOps/s 23.7369 KOps/s $\color{#d91a1a}-1.87\%$
test_simple 0.5532s 0.5527s 1.8093 Ops/s 1.7333 Ops/s $\color{#35bf28}+4.39\%$
test_transformed 1.2307s 1.1389s 0.8780 Ops/s 0.8747 Ops/s $\color{#35bf28}+0.38\%$
test_serial 1.6658s 1.6615s 0.6019 Ops/s 0.5912 Ops/s $\color{#35bf28}+1.80\%$
test_parallel 1.1722s 1.1008s 0.9084 Ops/s 0.8964 Ops/s $\color{#35bf28}+1.33\%$
test_step_mdp_speed[True-True-True-True-True] 0.1965ms 43.8014μs 22.8303 KOps/s 22.3537 KOps/s $\color{#35bf28}+2.13\%$
test_step_mdp_speed[True-True-True-True-False] 0.4414ms 24.9230μs 40.1236 KOps/s 40.0465 KOps/s $\color{#35bf28}+0.19\%$
test_step_mdp_speed[True-True-True-False-True] 0.4246ms 25.1967μs 39.6877 KOps/s 40.1336 KOps/s $\color{#d91a1a}-1.11\%$
test_step_mdp_speed[True-True-True-False-False] 37.9710μs 13.9608μs 71.6292 KOps/s 74.4318 KOps/s $\color{#d91a1a}-3.77\%$
test_step_mdp_speed[True-True-False-True-True] 0.4451ms 48.5627μs 20.5919 KOps/s 20.9858 KOps/s $\color{#d91a1a}-1.88\%$
test_step_mdp_speed[True-True-False-True-False] 0.4365ms 27.9741μs 35.7473 KOps/s 36.0063 KOps/s $\color{#d91a1a}-0.72\%$
test_step_mdp_speed[True-True-False-False-True] 67.0010μs 28.2066μs 35.4527 KOps/s 35.6249 KOps/s $\color{#d91a1a}-0.48\%$
test_step_mdp_speed[True-True-False-False-False] 0.4222ms 16.8349μs 59.4003 KOps/s 59.5401 KOps/s $\color{#d91a1a}-0.23\%$
test_step_mdp_speed[True-False-True-True-True] 0.4591ms 50.9763μs 19.6170 KOps/s 19.6627 KOps/s $\color{#d91a1a}-0.23\%$
test_step_mdp_speed[True-False-True-True-False] 0.4278ms 30.7611μs 32.5086 KOps/s 33.0118 KOps/s $\color{#d91a1a}-1.52\%$
test_step_mdp_speed[True-False-True-False-True] 59.8210μs 27.9325μs 35.8006 KOps/s 35.7526 KOps/s $\color{#35bf28}+0.13\%$
test_step_mdp_speed[True-False-True-False-False] 0.4232ms 16.7855μs 59.5753 KOps/s 60.3339 KOps/s $\color{#d91a1a}-1.26\%$
test_step_mdp_speed[True-False-False-True-True] 0.4579ms 53.7444μs 18.6066 KOps/s 18.9034 KOps/s $\color{#d91a1a}-1.57\%$
test_step_mdp_speed[True-False-False-True-False] 0.4386ms 33.6698μs 29.7002 KOps/s 30.3909 KOps/s $\color{#d91a1a}-2.27\%$
test_step_mdp_speed[True-False-False-False-True] 0.4397ms 30.5954μs 32.6847 KOps/s 32.9702 KOps/s $\color{#d91a1a}-0.87\%$
test_step_mdp_speed[True-False-False-False-False] 86.4520μs 19.2826μs 51.8603 KOps/s 51.2088 KOps/s $\color{#35bf28}+1.27\%$
test_step_mdp_speed[False-True-True-True-True] 0.4574ms 50.7989μs 19.6855 KOps/s 19.9968 KOps/s $\color{#d91a1a}-1.56\%$
test_step_mdp_speed[False-True-True-True-False] 0.4404ms 30.5725μs 32.7091 KOps/s 32.8738 KOps/s $\color{#d91a1a}-0.50\%$
test_step_mdp_speed[False-True-True-False-True] 2.3841ms 32.0562μs 31.1952 KOps/s 31.6688 KOps/s $\color{#d91a1a}-1.50\%$
test_step_mdp_speed[False-True-True-False-False] 42.5610μs 18.1934μs 54.9650 KOps/s 53.6284 KOps/s $\color{#35bf28}+2.49\%$
test_step_mdp_speed[False-True-False-True-True] 0.4731ms 53.7466μs 18.6058 KOps/s 18.9791 KOps/s $\color{#d91a1a}-1.97\%$
test_step_mdp_speed[False-True-False-True-False] 0.4406ms 33.2362μs 30.0877 KOps/s 30.0698 KOps/s $\color{#35bf28}+0.06\%$
test_step_mdp_speed[False-True-False-False-True] 62.3620μs 33.9857μs 29.4242 KOps/s 29.5340 KOps/s $\color{#d91a1a}-0.37\%$
test_step_mdp_speed[False-True-False-False-False] 0.4341ms 21.0122μs 47.5913 KOps/s 47.4274 KOps/s $\color{#35bf28}+0.35\%$
test_step_mdp_speed[False-False-True-True-True] 0.4616ms 56.1897μs 17.7969 KOps/s 17.8234 KOps/s $\color{#d91a1a}-0.15\%$
test_step_mdp_speed[False-False-True-True-False] 0.4375ms 36.0553μs 27.7352 KOps/s 27.7977 KOps/s $\color{#d91a1a}-0.23\%$
test_step_mdp_speed[False-False-True-False-True] 0.4340ms 34.1052μs 29.3211 KOps/s 29.6015 KOps/s $\color{#d91a1a}-0.95\%$
test_step_mdp_speed[False-False-True-False-False] 49.2710μs 20.9448μs 47.7445 KOps/s 47.8476 KOps/s $\color{#d91a1a}-0.22\%$
test_step_mdp_speed[False-False-False-True-True] 0.4698ms 57.4943μs 17.3930 KOps/s 17.3192 KOps/s $\color{#35bf28}+0.43\%$
test_step_mdp_speed[False-False-False-True-False] 0.4489ms 38.9697μs 25.6609 KOps/s 26.0178 KOps/s $\color{#d91a1a}-1.37\%$
test_step_mdp_speed[False-False-False-False-True] 0.4454ms 35.9551μs 27.8125 KOps/s 27.4964 KOps/s $\color{#35bf28}+1.15\%$
test_step_mdp_speed[False-False-False-False-False] 51.2410μs 23.2053μs 43.0936 KOps/s 42.1979 KOps/s $\color{#35bf28}+2.12\%$
test_values[generalized_advantage_estimate-True-True] 10.2880ms 9.8831ms 101.1833 Ops/s 98.0890 Ops/s $\color{#35bf28}+3.15\%$
test_values[vec_generalized_advantage_estimate-True-True] 20.1714ms 17.5315ms 57.0402 Ops/s 56.7899 Ops/s $\color{#35bf28}+0.44\%$
test_values[td0_return_estimate-False-False] 0.2479ms 0.1282ms 7.8026 KOps/s 7.7231 KOps/s $\color{#35bf28}+1.03\%$
test_values[td1_return_estimate-False-False] 28.1434ms 27.0852ms 36.9205 Ops/s 36.7868 Ops/s $\color{#35bf28}+0.36\%$
test_values[vec_td1_return_estimate-False-False] 18.0462ms 17.6758ms 56.5745 Ops/s 56.5350 Ops/s $\color{#35bf28}+0.07\%$
test_values[td_lambda_return_estimate-True-False] 42.5706ms 40.4429ms 24.7262 Ops/s 24.7828 Ops/s $\color{#d91a1a}-0.23\%$
test_values[vec_td_lambda_return_estimate-True-False] 18.3106ms 17.6370ms 56.6990 Ops/s 56.5875 Ops/s $\color{#35bf28}+0.20\%$
test_gae_speed[generalized_advantage_estimate-False-1-512] 9.4623ms 8.9509ms 111.7206 Ops/s 115.5461 Ops/s $\color{#d91a1a}-3.31\%$
test_gae_speed[vec_generalized_advantage_estimate-True-1-512] 1.8766ms 1.4760ms 677.4883 Ops/s 655.5299 Ops/s $\color{#35bf28}+3.35\%$
test_gae_speed[vec_generalized_advantage_estimate-False-1-512] 0.4518ms 0.4146ms 2.4122 KOps/s 2.4422 KOps/s $\color{#d91a1a}-1.23\%$
test_gae_speed[vec_generalized_advantage_estimate-True-32-512] 34.8880ms 33.6597ms 29.7091 Ops/s 28.8660 Ops/s $\color{#35bf28}+2.92\%$
test_gae_speed[vec_generalized_advantage_estimate-False-32-512] 2.1712ms 1.7220ms 580.7150 Ops/s 569.6291 Ops/s $\color{#35bf28}+1.95\%$
test_dqn_speed[False-None] 6.4075ms 1.4225ms 702.9827 Ops/s 695.6349 Ops/s $\color{#35bf28}+1.06\%$
test_dqn_speed[False-backward] 1.9535ms 1.9158ms 521.9848 Ops/s 523.7431 Ops/s $\color{#d91a1a}-0.34\%$
test_dqn_speed[True-None] 0.8675ms 0.5186ms 1.9283 KOps/s 1.9389 KOps/s $\color{#d91a1a}-0.54\%$
test_dqn_speed[True-backward] 1.0085ms 0.9762ms 1.0244 KOps/s 898.9201 Ops/s $\textbf{\color{#35bf28}+13.96\%}$
test_dqn_speed[reduce-overhead-None] 0.8894ms 0.5080ms 1.9683 KOps/s 1.8857 KOps/s $\color{#35bf28}+4.38\%$
test_dqn_speed[reduce-overhead-backward] 1.0439ms 0.9726ms 1.0282 KOps/s 885.2156 Ops/s $\textbf{\color{#35bf28}+16.15\%}$
test_ddpg_speed[False-None] 3.1647ms 2.8517ms 350.6694 Ops/s 340.9689 Ops/s $\color{#35bf28}+2.85\%$
test_ddpg_speed[False-backward] 4.2410ms 4.1287ms 242.2045 Ops/s 244.7357 Ops/s $\color{#d91a1a}-1.03\%$
test_ddpg_speed[True-None] 1.5386ms 1.3796ms 724.8735 Ops/s 730.5238 Ops/s $\color{#d91a1a}-0.77\%$
test_ddpg_speed[True-backward] 2.4519ms 2.3826ms 419.7131 Ops/s 377.5699 Ops/s $\textbf{\color{#35bf28}+11.16\%}$
test_ddpg_speed[reduce-overhead-None] 1.5530ms 1.3721ms 728.8033 Ops/s 718.1607 Ops/s $\color{#35bf28}+1.48\%$
test_ddpg_speed[reduce-overhead-backward] 2.4681ms 2.3966ms 417.2510 Ops/s 358.0501 Ops/s $\textbf{\color{#35bf28}+16.53\%}$
test_sac_speed[False-None] 8.4661ms 7.9805ms 125.3052 Ops/s 125.1638 Ops/s $\color{#35bf28}+0.11\%$
test_sac_speed[False-backward] 12.1192ms 11.3586ms 88.0392 Ops/s 87.9004 Ops/s $\color{#35bf28}+0.16\%$
test_sac_speed[True-None] 2.4347ms 2.2970ms 435.3532 Ops/s 427.9380 Ops/s $\color{#35bf28}+1.73\%$
test_sac_speed[True-backward] 4.4185ms 4.2339ms 236.1900 Ops/s 232.3227 Ops/s $\color{#35bf28}+1.66\%$
test_sac_speed[reduce-overhead-None] 2.4023ms 2.2771ms 439.1546 Ops/s 424.3943 Ops/s $\color{#35bf28}+3.48\%$
test_sac_speed[reduce-overhead-backward] 4.3159ms 4.2006ms 238.0590 Ops/s 219.0830 Ops/s $\textbf{\color{#35bf28}+8.66\%}$
test_redq_speed[False-None] 13.5349ms 10.3548ms 96.5732 Ops/s 97.1609 Ops/s $\color{#d91a1a}-0.60\%$
test_redq_speed[False-backward] 20.2129ms 17.8555ms 56.0050 Ops/s 55.6125 Ops/s $\color{#35bf28}+0.71\%$
test_redq_speed[True-None] 4.5643ms 4.3680ms 228.9391 Ops/s 224.3173 Ops/s $\color{#35bf28}+2.06\%$
test_redq_speed[True-backward] 10.0194ms 9.8353ms 101.6742 Ops/s 102.7853 Ops/s $\color{#d91a1a}-1.08\%$
test_redq_speed[reduce-overhead-None] 4.5787ms 4.3650ms 229.0951 Ops/s 234.1721 Ops/s $\color{#d91a1a}-2.17\%$
test_redq_speed[reduce-overhead-backward] 10.2041ms 9.9604ms 100.3976 Ops/s 99.7963 Ops/s $\color{#35bf28}+0.60\%$
test_redq_deprec_speed[False-None] 11.3486ms 10.9592ms 91.2474 Ops/s 89.9753 Ops/s $\color{#35bf28}+1.41\%$
test_redq_deprec_speed[False-backward] 16.4977ms 15.9905ms 62.5373 Ops/s 62.5834 Ops/s $\color{#d91a1a}-0.07\%$
test_redq_deprec_speed[True-None] 4.4916ms 4.3228ms 231.3318 Ops/s 229.8729 Ops/s $\color{#35bf28}+0.63\%$
test_redq_deprec_speed[True-backward] 8.7909ms 8.4730ms 118.0215 Ops/s 115.5698 Ops/s $\color{#35bf28}+2.12\%$
test_redq_deprec_speed[reduce-overhead-None] 4.7156ms 4.2803ms 233.6278 Ops/s 231.9303 Ops/s $\color{#35bf28}+0.73\%$
test_redq_deprec_speed[reduce-overhead-backward] 8.7507ms 8.4381ms 118.5103 Ops/s 115.1621 Ops/s $\color{#35bf28}+2.91\%$
test_td3_speed[False-None] 8.1705ms 7.9335ms 126.0482 Ops/s 126.4922 Ops/s $\color{#d91a1a}-0.35\%$
test_td3_speed[False-backward] 11.5982ms 10.8158ms 92.4576 Ops/s 92.7735 Ops/s $\color{#d91a1a}-0.34\%$
test_td3_speed[True-None] 1.8458ms 1.7951ms 557.0765 Ops/s 553.2678 Ops/s $\color{#35bf28}+0.69\%$
test_td3_speed[True-backward] 3.7157ms 3.6196ms 276.2710 Ops/s 278.7817 Ops/s $\color{#d91a1a}-0.90\%$
test_td3_speed[reduce-overhead-None] 1.8365ms 1.7656ms 566.3808 Ops/s 558.3530 Ops/s $\color{#35bf28}+1.44\%$
test_td3_speed[reduce-overhead-backward] 3.7851ms 3.6551ms 273.5888 Ops/s 274.4933 Ops/s $\color{#d91a1a}-0.33\%$
test_cql_speed[False-None] 28.6571ms 26.1227ms 38.2808 Ops/s 38.3241 Ops/s $\color{#d91a1a}-0.11\%$
test_cql_speed[False-backward] 38.8673ms 35.6162ms 28.0771 Ops/s 28.1399 Ops/s $\color{#d91a1a}-0.22\%$
test_cql_speed[True-None] 16.3873ms 12.4087ms 80.5885 Ops/s 81.8356 Ops/s $\color{#d91a1a}-1.52\%$
test_cql_speed[True-backward] 18.6036ms 18.3023ms 54.6380 Ops/s 56.0898 Ops/s $\color{#d91a1a}-2.59\%$
test_cql_speed[reduce-overhead-None] 12.6665ms 12.3955ms 80.6747 Ops/s 81.2726 Ops/s $\color{#d91a1a}-0.74\%$
test_cql_speed[reduce-overhead-backward] 18.4931ms 18.1820ms 54.9995 Ops/s 55.8236 Ops/s $\color{#d91a1a}-1.48\%$
test_a2c_speed[False-None] 5.9413ms 5.4267ms 184.2735 Ops/s 184.3903 Ops/s $\color{#d91a1a}-0.06\%$
test_a2c_speed[False-backward] 12.1309ms 11.7362ms 85.2061 Ops/s 84.1842 Ops/s $\color{#35bf28}+1.21\%$
test_a2c_speed[True-None] 4.1451ms 3.7208ms 268.7589 Ops/s 266.6323 Ops/s $\color{#35bf28}+0.80\%$
test_a2c_speed[True-backward] 9.0840ms 8.6744ms 115.2821 Ops/s 113.2598 Ops/s $\color{#35bf28}+1.79\%$
test_a2c_speed[reduce-overhead-None] 4.0949ms 3.6861ms 271.2863 Ops/s 269.4842 Ops/s $\color{#35bf28}+0.67\%$
test_a2c_speed[reduce-overhead-backward] 9.1947ms 8.7487ms 114.3027 Ops/s 109.6442 Ops/s $\color{#35bf28}+4.25\%$
test_ppo_speed[False-None] 7.0004ms 5.9427ms 168.2744 Ops/s 168.4482 Ops/s $\color{#d91a1a}-0.10\%$
test_ppo_speed[False-backward] 12.7762ms 12.4643ms 80.2293 Ops/s 79.1555 Ops/s $\color{#35bf28}+1.36\%$
test_ppo_speed[True-None] 3.9728ms 3.6090ms 277.0835 Ops/s 272.8733 Ops/s $\color{#35bf28}+1.54\%$
test_ppo_speed[True-backward] 8.9228ms 8.5227ms 117.3335 Ops/s 117.4240 Ops/s $\color{#d91a1a}-0.08\%$
test_ppo_speed[reduce-overhead-None] 3.9233ms 3.6175ms 276.4337 Ops/s 275.0292 Ops/s $\color{#35bf28}+0.51\%$
test_ppo_speed[reduce-overhead-backward] 9.1157ms 8.7540ms 114.2338 Ops/s 109.0653 Ops/s $\color{#35bf28}+4.74\%$
test_reinforce_speed[False-None] 4.9792ms 4.5773ms 218.4693 Ops/s 214.0023 Ops/s $\color{#35bf28}+2.09\%$
test_reinforce_speed[False-backward] 7.8297ms 7.4363ms 134.4754 Ops/s 132.7484 Ops/s $\color{#35bf28}+1.30\%$
test_reinforce_speed[True-None] 3.1884ms 2.8685ms 348.6196 Ops/s 342.4636 Ops/s $\color{#35bf28}+1.80\%$
test_reinforce_speed[True-backward] 7.9300ms 7.6897ms 130.0445 Ops/s 130.5615 Ops/s $\color{#d91a1a}-0.40\%$
test_reinforce_speed[reduce-overhead-None] 3.1872ms 2.8503ms 350.8437 Ops/s 336.8360 Ops/s $\color{#35bf28}+4.16\%$
test_reinforce_speed[reduce-overhead-backward] 8.1461ms 7.9328ms 126.0591 Ops/s 124.5701 Ops/s $\color{#35bf28}+1.20\%$
test_iql_speed[False-None] 24.2305ms 20.1686ms 49.5820 Ops/s 48.1032 Ops/s $\color{#35bf28}+3.07\%$
test_iql_speed[False-backward] 34.6493ms 31.2531ms 31.9969 Ops/s 31.6782 Ops/s $\color{#35bf28}+1.01\%$
test_iql_speed[True-None] 8.9712ms 8.5956ms 116.3389 Ops/s 110.5473 Ops/s $\textbf{\color{#35bf28}+5.24\%}$
test_iql_speed[True-backward] 17.7770ms 17.3403ms 57.6692 Ops/s 58.3389 Ops/s $\color{#d91a1a}-1.15\%$
test_iql_speed[reduce-overhead-None] 9.0008ms 8.6583ms 115.4962 Ops/s 113.8504 Ops/s $\color{#35bf28}+1.45\%$
test_iql_speed[reduce-overhead-backward] 18.0462ms 17.6680ms 56.5994 Ops/s 57.0556 Ops/s $\color{#d91a1a}-0.80\%$
test_rb_sample[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 7.4813ms 6.0398ms 165.5673 Ops/s 166.4707 Ops/s $\color{#d91a1a}-0.54\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 0.5381s 0.7358ms 1.3590 KOps/s 2.7119 KOps/s $\textbf{\color{#d91a1a}-49.89\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.5867ms 0.3373ms 2.9649 KOps/s 3.7611 KOps/s $\textbf{\color{#d91a1a}-21.17\%}$
test_rb_sample[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 6.0099ms 5.7097ms 175.1408 Ops/s 173.5145 Ops/s $\color{#35bf28}+0.94\%$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.9359ms 0.3343ms 2.9909 KOps/s 2.8060 KOps/s $\textbf{\color{#35bf28}+6.59\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.5747ms 0.3258ms 3.0694 KOps/s 3.8237 KOps/s $\textbf{\color{#d91a1a}-19.73\%}$
test_rb_sample[TensorDictReplayBuffer-LazyMemmapStorage-sampler6-10000] 1.6124ms 1.3162ms 759.7366 Ops/s 704.7270 Ops/s $\textbf{\color{#35bf28}+7.81\%}$
test_rb_sample[TensorDictReplayBuffer-LazyTensorStorage-sampler7-10000] 1.5786ms 1.2632ms 791.6678 Ops/s 801.0115 Ops/s $\color{#d91a1a}-1.17\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.0258ms 5.9116ms 169.1583 Ops/s 169.3322 Ops/s $\color{#d91a1a}-0.10\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 1.7776ms 0.4820ms 2.0746 KOps/s 2.0716 KOps/s $\color{#35bf28}+0.14\%$
test_rb_sample[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8449ms 0.4892ms 2.0441 KOps/s 2.0003 KOps/s $\color{#35bf28}+2.19\%$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-RandomSampler-4000] 5.8778ms 5.7621ms 173.5481 Ops/s 173.7148 Ops/s $\color{#d91a1a}-0.10\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-10000] 1.9388ms 0.3406ms 2.9357 KOps/s 3.0614 KOps/s $\color{#d91a1a}-4.11\%$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-10000] 0.5605ms 0.3029ms 3.3015 KOps/s 3.7394 KOps/s $\textbf{\color{#d91a1a}-11.71\%}$
test_rb_iterate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-4000] 5.9518ms 5.6946ms 175.6062 Ops/s 174.7543 Ops/s $\color{#35bf28}+0.49\%$
test_rb_iterate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-10000] 0.7399ms 0.2810ms 3.5592 KOps/s 3.2059 KOps/s $\textbf{\color{#35bf28}+11.02\%}$
test_rb_iterate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-10000] 0.4633ms 0.2631ms 3.8010 KOps/s 3.3755 KOps/s $\textbf{\color{#35bf28}+12.61\%}$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-ListStorage-None-4000] 6.1189ms 5.9150ms 169.0622 Ops/s 168.4657 Ops/s $\color{#35bf28}+0.35\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-10000] 0.8962ms 0.4615ms 2.1667 KOps/s 2.2628 KOps/s $\color{#d91a1a}-4.25\%$
test_rb_iterate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-10000] 0.8058ms 0.5057ms 1.9774 KOps/s 2.3609 KOps/s $\textbf{\color{#d91a1a}-16.25\%}$
test_rb_populate[TensorDictReplayBuffer-ListStorage-RandomSampler-400] 6.8055ms 5.0729ms 197.1247 Ops/s 192.6888 Ops/s $\color{#35bf28}+2.30\%$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-RandomSampler-400] 8.5234ms 2.0409ms 489.9679 Ops/s 493.9038 Ops/s $\color{#d91a1a}-0.80\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-RandomSampler-400] 7.2259ms 1.2171ms 821.6500 Ops/s 814.0508 Ops/s $\color{#35bf28}+0.93\%$
test_rb_populate[TensorDictReplayBuffer-ListStorage-SamplerWithoutReplacement-400] 0.4628s 14.3406ms 69.7320 Ops/s 192.1277 Ops/s $\textbf{\color{#d91a1a}-63.71\%}$
test_rb_populate[TensorDictReplayBuffer-LazyMemmapStorage-SamplerWithoutReplacement-400] 10.2189ms 2.0766ms 481.5627 Ops/s 485.0375 Ops/s $\color{#d91a1a}-0.72\%$
test_rb_populate[TensorDictReplayBuffer-LazyTensorStorage-SamplerWithoutReplacement-400] 6.3683ms 1.1695ms 855.0667 Ops/s 819.1017 Ops/s $\color{#35bf28}+4.39\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-ListStorage-None-400] 6.9113ms 5.3118ms 188.2589 Ops/s 58.8575 Ops/s $\textbf{\color{#35bf28}+219.86\%}$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyMemmapStorage-None-400] 10.7835ms 2.2468ms 445.0810 Ops/s 468.4578 Ops/s $\color{#d91a1a}-4.99\%$
test_rb_populate[TensorDictPrioritizedReplayBuffer-LazyTensorStorage-None-400] 3.6371ms 1.2565ms 795.8384 Ops/s 973.3362 Ops/s $\textbf{\color{#d91a1a}-18.24\%}$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-True] 36.2276ms 33.4679ms 29.8794 Ops/s 29.5112 Ops/s $\color{#35bf28}+1.25\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-10000-10000-100-False] 19.4668ms 17.7890ms 56.2144 Ops/s 56.7956 Ops/s $\color{#d91a1a}-1.02\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-True] 36.6128ms 34.5361ms 28.9552 Ops/s 28.2718 Ops/s $\color{#35bf28}+2.42\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-100000-10000-100-False] 19.4460ms 18.0968ms 55.2585 Ops/s 54.9628 Ops/s $\color{#35bf28}+0.54\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-True] 37.9542ms 36.3884ms 27.4813 Ops/s 27.0956 Ops/s $\color{#35bf28}+1.42\%$
test_rb_extend_sample[ReplayBuffer-LazyTensorStorage-RandomSampler-1000000-10000-100-False] 21.9421ms 19.6546ms 50.8787 Ops/s 52.1970 Ops/s $\color{#d91a1a}-2.53\%$

@vmoens vmoens force-pushed the fixes branch 2 times, most recently from 0bc8ed6 to 2e73a09 Compare November 10, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vmoens