Skip to content

Use rebase merge for commit hash update PRs #6731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

XuehaiPan
Copy link

No description provided.

Copy link

vercel bot commented Jun 10, 2025

@XuehaiPan is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 10, 2025
@clee2000
Copy link
Contributor

Isn't this a noop? iirc hash updates pull origin, make their changes, then force push to update the branch

@XuehaiPan
Copy link
Author

XuehaiPan commented Jun 13, 2025

Isn't this a noop? iirc hash updates pull origin, make their changes, then force push to update the branch

@clee2000 Yes. You are correct.

I updated the PR to make viable/rebase work as expected. This will make the commit hash update PR can be merged more smoothly and reduce CI time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants