[BE] Refactor dependency update code #6735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
facebook-github-bot
added
the
CLA Signed
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tinglvv
approved these changes
Jun 10, 2025
atalman
commented
Jun 10, 2025
| "mkl", | ||
| ] | ||
| } | ||
| PACKAGES_PER_PROJECT = [ |
There was a problem hiding this comment.
We should move this in separate json file in next iteration of this code
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
huydhn
reviewed
Jun 11, 2025
| {"package": "nvidia-cudnn-cu11", "version": "latest", "project": "torch"}, | ||
| {"package": "nvidia-cudnn-cu12", "version": "latest", "project": "torch"}, | ||
| {"package": "typing-extensions", "version": "latest", "project": "torch"}, | ||
| {"package": "nvidia-cuda-nvrtc-cu12", "version": "12.9.86", "project": "torch", "target": "cu129"}, |
There was a problem hiding this comment.
Does these lines mean that these dependencies are only used for the upcoming CUDA 12.9? I also see these packages from older CUDA versions, i.e. 12.8 so should they (older CUDA pins) be here too? I guess a comment would be clearer
There was a problem hiding this comment.
I think we can add dependencies as we go here
huydhn
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should enable Nvidia, Intel, AMD to submit PRs for updating the dependent libraries