Add cloudwatch_logs.py utility file to monitor lambdas #6740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Reorganized import statements for better clarity. - Standardized string formatting and spacing throughout the code. - Enhanced function definitions and comments for better understanding. - Improved error handling and logging for AWS interactions. - Updated README.md to remove unnecessary newline.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
facebook-github-bot
added
the
CLA Signed
malfet
approved these changes
Jun 11, 2025
| from typing import Any, Dict, List, Optional | ||
|
|
||
| import boto3 # type: ignore[import-untyped] | ||
| import dateparser # type: ignore[import-untyped] |
There was a problem hiding this comment.
Not a fan of custom dependency to be frank..
Comment on lines
299
to
312
| if options.output_file: | ||
| # Write to output file | ||
| with open(options.output_file, "w", encoding="utf-8") as f: | ||
| f.writelines(header) | ||
| for log_content in all_logs: | ||
| f.write(log_content) | ||
| print(f"Downloaded logs to: {options.output_file}") | ||
| else: | ||
| # Write to stdout | ||
| import sys | ||
|
|
||
| sys.stdout.writelines(header) | ||
| for log_content in all_logs: | ||
| sys.stdout.write(log_content) |
There was a problem hiding this comment.
Why not combine this logic to something like
def write_logs(f):
f.writelines(header)
for log_content in all_logs:
f.write(log_content)
if options.output_file:
with open(options.output_file, "w", encoding="utf-8") as f:
write_logs(f)
else:
write_logs(sys.stdout)
malfet
reviewed
Jun 11, 2025
| except NoCredentialsError: | ||
| print( | ||
| "Error: AWS credentials not found. Please configure your AWS credentials." | ||
| ) |
There was a problem hiding this comment.
sys.exit(-1) seems to be in order here
Comment on lines
318
to
323
| except ValueError as e: | ||
| print(f"Error: {e}") | ||
| except ClientError as e: | ||
| print(f"AWS Error: {e}") | ||
| except Exception as e: | ||
| print(f"Unexpected error: {e}") |
There was a problem hiding this comment.
Again, what's the value of catching those errors? If script fails, it should fail and return non-zero status code, but right now it's not the case
Signed-off-by: Eli Uriegas <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -0,0 +1,326 @@ | |||
| import argparse | |||
Check warning
Code scanning / lintrunner
PYFMT/format Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a cloudwatch_logs.py utility file in order to make it easier to debug lambdas if / when things go awry.
Example usage: