Skip to content

Conversation

ZainRizvi
Copy link
Contributor

Two motivations behind adding this:

  1. Make it easier for other contributors to update bots (as we'd like to encourage others to directly update these for their use cases instead of asking the Dev Infra team to support all repos)
  2. Make it easier to use LLMs with these

Copy link

vercel bot commented Sep 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
torchci Ready Ready Preview Sep 19, 2025 10:27pm

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 19, 2025
@ZainRizvi ZainRizvi requested a review from a team September 19, 2025 22:27
Copy link
Contributor

@clee2000 clee2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the middle section for "detailed bot analysis", but I feel like there is unusual emphasis on certain things in the other parts and some of the headings/groups are odd. Some things I found odd are

  • why are the command parser and command handler entrypoints?
  • are Constants.ts and subscriptions.ts really configuration files?
  • things in Key Features feel like they should either be in bot analysis or the core architecture

Some things that I noticed that I don't think are correct

  • Uses ML/analytics data from ClickHouse to make intelligent retry decisions
  • **Monitoring**: DynamoDB logging + external Dr. CI dashboard
  • nit CI flow should probably be ciflow if only for consistency with other comments in the codebase

Then again, we don't really use correct or consistent terminology either when referring to most of these so idk

Not related to this PR but there are probably a bunch of bots we can get rid of (edit: #7195)

@zxiiro
Copy link
Collaborator

zxiiro commented Sep 22, 2025

Thanks for documenting this. I did not realize there were so many bots!

@ZainRizvi ZainRizvi merged commit d25228b into main Sep 22, 2025
5 checks passed
@ZainRizvi ZainRizvi deleted the zainr/bot-docs branch September 22, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants