Fix compatibility issue with EmbeddingBag for IEN Publish #3181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78125516 |
chelqxz
added a commit
to chelqxz/torchrec
that referenced
this pull request
Jul 10, 2025
Summary: Discovered when working on fix a ien e2e test https://fb.workplace.com/groups/gpuinference/permalink/3213711332110846/ This is not ideal fix, new field will introduce incompatibility again in the future. Following up in post for better solution Reviewed By: faran928 Differential Revision: D78125516
chelqxz
force-pushed
the
export-D78125516
branch
from
001f81b to
0e16eab
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78125516 |
chelqxz
added a commit
to chelqxz/torchrec
that referenced
this pull request
Jul 11, 2025
Summary: Pull Request resolved: pytorch#3181 Discovered when working on fix a ien e2e test https://fb.workplace.com/groups/gpuinference/permalink/3213711332110846/ This is not ideal fix, new field will introduce incompatibility again in the future. Following up in post for better solution Reviewed By: faran928 Differential Revision: D78125516
chelqxz
force-pushed
the
export-D78125516
branch
2 times, most recently
from
772cd2c to
94e2200
Compare
chelqxz
added a commit
to chelqxz/torchrec
that referenced
this pull request
Jul 11, 2025
Summary: Discovered when working on fix a ien e2e test https://fb.workplace.com/groups/gpuinference/permalink/3213711332110846/ This is not ideal fix, new field will introduce incompatibility again in the future. Following up in post for better solution Reviewed By: hannaxu, faran928 Differential Revision: D78125516
chelqxz
added a commit
to chelqxz/torchrec
that referenced
this pull request
Jul 11, 2025
Summary: Pull Request resolved: pytorch#3181 Discovered when working on fix a ien e2e test https://fb.workplace.com/groups/gpuinference/permalink/3213711332110846/ This is not ideal fix, new field will introduce incompatibility again in the future. Following up in post for better solution Reviewed By: hannaxu, faran928 Differential Revision: D78125516
chelqxz
force-pushed
the
export-D78125516
branch
from
94e2200 to
33da1f6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78125516 |
chelqxz
force-pushed
the
export-D78125516
branch
from
33da1f6 to
fcd60f9
Compare
chelqxz
added a commit
to chelqxz/torchrec
that referenced
this pull request
Jul 11, 2025
Summary: Discovered when working on fix a ien e2e test https://fb.workplace.com/groups/gpuinference/permalink/3213711332110846/ This is not ideal fix, new field will introduce incompatibility again in the future. Following up in post for better solution Reviewed By: hannaxu, faran928 Differential Revision: D78125516
|
This pull request was exported from Phabricator. Differential Revision: D78125516 |
Summary: Discovered when working on fix a ien e2e test https://fb.workplace.com/groups/gpuinference/permalink/3213711332110846/ This is not ideal fix, new field will introduce incompatibility again in the future. Following up in post for better solution Reviewed By: hannaxu, faran928 Differential Revision: D78125516
chelqxz
force-pushed
the
export-D78125516
branch
from
fcd60f9 to
aaa1306
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78125516 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Discovered when working on fix a ien e2e test https://fb.workplace.com/groups/gpuinference/permalink/3213711332110846/
This is not ideal fix, new field will introduce incompatibility again in the future. Following up in post for better solution
Reviewed By: faran928
Differential Revision: D78125516